Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Node.js version requirement #271

Merged
merged 1 commit into from
May 22, 2024
Merged

feat: Update Node.js version requirement #271

merged 1 commit into from
May 22, 2024

Conversation

wakamsha
Copy link
Contributor

@wakamsha wakamsha commented May 21, 2024 •
edited
Loading

BREAKING CHANGE:

Update Node.js engine requirement to >= 18.18.0 || >= 20.0.0. This means we are dropping support for Node 18 versions prior to 18.18.0.

Context

To update @typescript-eslint from the current v6 to v7, we need to increase the minimum Node.js version to v18.18.0.

References

@wakamsha wakamsha self-assigned this May 21, 2024
@wakamsha wakamsha mentioned this pull request May 21, 2024
Merged
@wakamsha
feat: Update Node.js version requirement
39db7b9 
BREAKING CHANGE:

Update Node.js engine requirement to `>= 18.18.0 || >= 20.0.0`. This means we are dropping support for Node 18 versions prior to `18.18.0`.
@wakamsha wakamsha force-pushed the feat/update-nodejs-requirement branch from cf14a8d to 39db7b9 Compare May 22, 2024 04:34
@wakamsha wakamsha marked this pull request as ready for review May 22, 2024 04:38
@tongari07
Copy link
Contributor

Is this a breaking change for those using Node.js engine below 18.18.0?

@wakamsha
Copy link
Contributor Author

yes

tongari07
tongari07 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@tongari07 tongari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tongari07
Copy link
Contributor

tongari07 commented May 22, 2024 •
edited
Loading

I see! In addition to putting "BREAKING CHANGE:`" in the PR description, I also thought that the PR title (which would be the commit comment) needed the "! (exclamation point)" mark in the PR title (which will be the commit comment) as well as in the PR description.
However, I found that it is fine to have one or the other in the Conventional Commit, so that was not a problem.

@wakamsha
Copy link
Contributor Author

wakamsha commented May 22, 2024 •
edited
Loading

The README states that it's possible to make semantic-release recognize "conventional commit" using ! (exclamation point) by changing the setting of @semantic-release/commit-analyzer.

I also wanted to use ! and tried this setting, but @semantic-release/elease-notes-generator didn't work and crashed. The cause is unknown.

Since I couldn't find a solution, I decided to continue including BREAKING CHANGE string in the commit message.

@wakamsha wakamsha merged commit 44d7fe3 into main May 22, 2024
4 checks passed
@wakamsha wakamsha deleted the feat/update-nodejs-requirement branch May 22, 2024 08:27
@wakamsha wakamsha mentioned this pull request May 29, 2024
Closed
oss-frontend-github-app bot pushed a commit that referenced this pull request Jun 20, 2024
@semantic-release-bot
chore(release): 4.0.0
5ca591f 
# [4.0.0](3.0.0...4.0.0) (2024-06-20)

### Bug Fixes

* `import/namespace` error ([#294](#294)) ([a512fed](a512fed))
* Allow import of devDependency modules in Storybook files ([#279](#279)) ([1503dbe](1503dbe))
* Resolve the problem of incorrect recognition of alias path by TypeScript's Compiler Options ([#293](#293)) ([39c4f0a](39c4f0a))
* Specify `jest` as a Peer Dependency ([#298](#298)) ([4f750da](4f750da))

### Features

* Implement the Flat Config ([#300](#300)) ([0a16caf](0a16caf))
* Remove deprecated rule settings ([#295](#295)) ([b264582](b264582))
* Update ESLint version requirement ([#272](#272)) ([e2e952a](e2e952a))
* Update eslint-plugin-jest version ([#275](#275)) ([9f31624](9f31624))
* Update eslint-plugin-n version ([#274](#274)) ([5e5ce78](5e5ce78))
* Update eslint-plugin-testing-library version ([#277](#277)) ([9d23602](9d23602))
* Update Node.js version requirement ([#271](#271)) ([44d7fe3](44d7fe3))
* Update typescript-eslint version ([#273](#273)) ([64042cb](64042cb))

### BREAKING CHANGES

* [Update eslint-plugin-testing-library version to 6 higher](https://github.com/testing-library/eslint-plugin-testing-library/releases/tag/v6.0.0)
* Update the TypeScript peer dependency requirement to `>= 4.7.5 || ^5.0.0`. This means we are dropping support for TypeScript 4 versions prior to `4.7.5`.

* fix version
* Update the ESLint peer dependency requirement to `^8.56.0`. This means we are dropping support for ESLint 8 versions prior to `8.56.0`.

* chore: specify eslint version in ci only v8
* Update Node.js engine requirement to `>= 18.18.0 || >= 20.0.0`. This means we are dropping support for Node 18 versions prior to `18.18.0`.
@oss-frontend-github-app
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongari07 tongari07 tongari07 approved these changes

@taigakiyokawa taigakiyokawa Awaiting requested review from taigakiyokawa

Assignees

@wakamsha wakamsha

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wakamsha @tongari07