Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update TypeScript Rules and Config to support ESLint v9 #338

Merged
merged 7 commits into from
Dec 9, 2024
Merged

feat!: Update TypeScript Rules and Config to support ESLint v9 #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f48795f
update deps
wakamsha Nov 29, 2024
c34daf8
remove deleted rule
wakamsha Nov 29, 2024
1b13049
update config for flat
wakamsha Nov 29, 2024
00619c9
update snapshot
wakamsha Nov 29, 2024
05928c5
delete unnecessary dummy files
wakamsha Nov 29, 2024
fca31d3
feat!: Update Node.js and TypeScript version requirement
wakamsha Nov 29, 2024
7dc9b7b
update deps
wakamsha Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 22 additions & 26 deletions configs/flat/typescript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,34 @@
// @ts-check
import typescriptEslint from '@typescript-eslint/eslint-plugin';
import typescriptEslintParser from '@typescript-eslint/parser';
import tseslint from 'typescript-eslint';
import typescriptRuleSetBase from '../../rules/typescript.js';

const typescriptRuleSet = {
plugins: {
'@typescript-eslint': typescriptEslint,
},
rules: {
...typescriptEslint.configs['eslint-recommended'].overrides?.[0].rules,
...typescriptEslint.configs['strict-type-checked'].rules,
...typescriptEslint.configs['stylistic-type-checked'].rules,
...typescriptRuleSetBase.rules,
'@typescript-eslint': tseslint.plugin,
},
extends: [
...tseslint.configs.strictTypeChecked,
...tseslint.configs.stylisticTypeChecked,
],
rules: typescriptRuleSetBase.rules,
};

export default [
{
files: ['**/*.@(ts|tsx|cts|mts)'],
export default tseslint.config({
files: ['**/*.@(ts|tsx|cts|mts)'],

languageOptions: {
parser: typescriptEslintParser,
parserOptions: {
project: true,
},
languageOptions: {
parser: tseslint.parser,
parserOptions: {
projectService: true,
tsconfigRootDir: process.env.TSCONFIG_ROOT_DIR ?? import.meta.dirname,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is necessary to automatically detect the nearest tsconfig.json.

However, it's not desirable to reference import.meta.dirname when running snapshot test, so a dummy path is assigned to process.env.TSCONFIG_ROOT_DIR only during snapshot test to prevent import.meta.dirname from being referenced.

see: @typescript-eslint/parser | typescript-eslint

},

settings: {
// https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#importparsers
'import/parsers': {
'@typescript-eslint/parser': ['.ts', '.tsx', '.cts', '.mts'],
},
settings: {
// https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#importparsers
'import/parsers': {
'@typescript-eslint/parser': ['.ts', '.tsx', '.cts', '.mts'],
},

...typescriptRuleSet,
},
];

...typescriptRuleSet,
});
Loading
Loading