Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-config): Update typescript-eslint deps #366

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat(eslint-config): Update typescript-eslint deps #366

merged 1 commit into from
Feb 13, 2025

Conversation

wakamsha
Copy link
Contributor

@wakamsha wakamsha commented Feb 12, 2025 •
edited
Loading

What changed / motivation ?

Between version 8.16.0 and 8.23.0 of typescript-eslint it may occur the following error:

ESLint: 9.20.0

TypeError: Error while loading rule '@typescript-eslint/no-empty-function': Cannot read properties of undefined (reading 'allow')
...

To avoid this, update to the current latest version.

Btw, this modification adds new rules, but this is in the category of minor updates.

Linked PR / Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha wakamsha self-assigned this Feb 12, 2025
@wakamsha wakamsha force-pushed the feat/update-typescript-eslint branch from d0f448a to 31163f0 Compare February 12, 2025 10:48
keroken
keroken approved these changes Feb 13, 2025
View reviewed changes
Copy link

@keroken keroken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@wakamsha wakamsha merged commit 719d2da into main Feb 13, 2025
2 checks passed
@wakamsha wakamsha deleted the feat/update-typescript-eslint branch February 13, 2025 01:27
oss-frontend-github-app bot pushed a commit that referenced this pull request Feb 13, 2025
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
ef0045d 
## [eslint-config-moneyforward-v5.1.0](5.0.2...5.1.0) (2025-02-13)

### Features

* **eslint-config:** Update `typescript-eslint` deps ([#366](#366)) ([719d2da](719d2da))

### Bug Fixes

* **eslint-config:** Fix the repository url ([#365](#365)) ([87beb0c](87beb0c))
@oss-frontend-github-app
Copy link

🎉 This PR is included in version eslint-config-moneyforward-v5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keroken keroken keroken approved these changes

@taigakiyokawa taigakiyokawa Awaiting requested review from taigakiyokawa

@tongari07 tongari07 Awaiting requested review from tongari07

Assignees

@wakamsha wakamsha

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wakamsha @keroken