Recommend the stdlib atomic types instead of go.uber.org/atomic #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
force-pushed
the
atomics
branch
2 times, most recently
from
f486e62 to
06bae45
Compare
edaniels
reviewed
Feb 13, 2025
src/atomic.md
Outdated
| [sync/atomic]: https://pkg.go.dev/sync/atomic | ||
| <!-- | ||
|
|
||
| TODO: It'd be nice to have a shared library that provided a typed atomic value instead of having |
There was a problem hiding this comment.
There's https://pkg.go.dev/sync/atomic#Pointer for that
There was a problem hiding this comment.
ah I see that file is proposing a typed value, not a pointer. That being said, could we actually leave out discussion like this from within the files? Might be better placed elsewhere like an issue or ticket, just so these don't add up and become harder to action.
edaniels
requested changes
Feb 13, 2025
style.md
Outdated
|
|
||
| <!-- | ||
|
|
||
| TODO: It'd be nice to have a shared library that provided a typed atomic value instead of having |
There was a problem hiding this comment.
Note that style.md is just a generated cat of all the individual files in src. I will update .gitattributes so it shows up as a generated file in the PR Files Changed view.
|
@pjjw Ping ... |
pjjw
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uber's package predates the new types added in Go 1.19. The new stdlib types provide more or less the same functionality as Uber's.