Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ssdlc compliance flow #29

Merged
merged 4 commits into from
Jun 28, 2024
Merged

chore: ssdlc compliance flow #29

merged 4 commits into from
Jun 28, 2024

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Jun 25, 2024

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title ssdlc compliance chore: ssdlc compliance flow Jun 28, 2024
@baileympearson baileympearson marked this pull request as ready for review June 28, 2024 15:24
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 28, 2024
@nbbeeken nbbeeken self-assigned this Jun 28, 2024
@nbbeeken nbbeeken merged commit 2c0b2f5 into main Jun 28, 2024
10 checks passed
@nbbeeken nbbeeken deleted the ssdlc branch June 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants