-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-6626): implement integration tests for improved client.close() - server-side #4367
Open
aditi-khare-mongoDB
wants to merge
16
commits into
main
Choose a base branch
from
NODE-6626/server-side
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+211
−28
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8f7eb85
parent 70d476aa0be7e60b62c543596f6b2ff6a7c0e8c2
aditi-khare-mongoDB 08d8c26
clean up
aditi-khare-mongoDB 24dcee8
lint
aditi-khare-mongoDB 6a70114
txn test fix
aditi-khare-mongoDB e719fa9
Merge branch 'main' into NODE-6626/server-side
aditi-khare-mongoDB 689706b
test fixes
aditi-khare-mongoDB 74673f8
Merge branch 'main' into NODE-6626/server-side
aditi-khare-mongoDB 6629343
await collection creation - fix txn test
aditi-khare-mongoDB 729c269
test(NODE-4955): sync unacknowledged write spec tests (#4380)
W-A-James f2f8dce
failing test fixed
aditi-khare-mongoDB 35435db
currentOp requires >=4.2
aditi-khare-mongoDB 0f7d8ba
Merge branch 'main' into NODE-6626/server-side
aditi-khare-mongoDB 3c98214
requested changes
aditi-khare-mongoDB f53ecc6
$currentOp idleCursors needs >= 4.2
aditi-khare-mongoDB 1d3fd91
bug fixed
aditi-khare-mongoDB 429a20b
Merge branch 'main' into NODE-6626/server-side
aditi-khare-mongoDB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that this related to fixing the server side issue. We've changed the meaning of killed include cursors that didn't actually run kill cursors
I'm not sure that's a change we can make here, maybe there's another approach to whatever moving this variable addressed?