fix(NODE-6407): use conversationId returned from server in saslContinue #4368
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…hardcoded integer in SASL implementation for MONGODB-AWS. (#4258)
baileympearson
added
the
Primary Review
baileympearson
previously approved these changes
Jan 24, 2025
|
@W-A-James Lint failure |
baileympearson
added
Team Review
durran
approved these changes
Jan 31, 2025
dariakp
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (copied from #4258)
MONGODB-AWSauthentication mechanism should follow SASL spec. Current implementation ignores theconversationIdsent by the server and uses a hardcoded integer for allsaslContinuemessages across all conversations.What is changing?
conversationIdto utilize the one that gets returned in thesaslStartresponse.Is there new documentation needed for these changes?
No. This change brings the implementation to spec.
What is the motivation for this change?
This is a bug. MONGODB-AWS authentication failed on database emulating MongoDB.
Release Highlight
MONGODB-AWSauthentication mechanism will now use theconversationIdsent by the serverImportant
This bug never impacted genuine MongoDB connectivity to Atlas, Enterprise or Community.
AWS IAM authentication has been supported since MongoDB 4.4, and could be used successfully from the Node.js driver's
MONGODB-AWSSASL implementation. Unofficial implementations of MongoDB, however, failed when trying to use this authentication mechanism as theconversationIdwas hardcoded by the driver instead of using the value returned by the server.Thanks to @kggau for contributing this fix!
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript