Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-6692): check that event emitters have error listeners #4382

Merged
merged 4 commits into from
Feb 5, 2025
Merged

test(NODE-6692): check that event emitters have error listeners #4382

merged 4 commits into from
Feb 5, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 28, 2025 •
edited
Loading

Description

What is changing?

  • WIP: trying this out to see how much needs fixing potentially
Is there new documentation needed for these changes?

What is the motivation for this change?

  • When working on close resources uncaught errors were being thrown, this is a small side effort to make sure we're not making event emitters that don't have their error event subscribed to

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the test-santize-ee branch 3 times, most recently from fbad7ba to 9ba7a8a Compare January 28, 2025 20:31
@nbbeeken nbbeeken closed this Jan 28, 2025
@nbbeeken nbbeeken reopened this Jan 28, 2025
@nbbeeken nbbeeken force-pushed the test-santize-ee branch 2 times, most recently from 3a7f111 to 09742f5 Compare January 28, 2025 22:00
@nbbeeken nbbeeken changed the title test: check that event emitters have error listeners in the same tick of their creation test(NODE-6692): check that event emitters have error listeners Jan 28, 2025
@nbbeeken nbbeeken force-pushed the test-santize-ee branch 6 times, most recently from ba36dea to e8c9032 Compare January 30, 2025 18:52
@nbbeeken nbbeeken marked this pull request as ready for review January 31, 2025 16:55
@nbbeeken nbbeeken requested a review from a team as a code owner January 31, 2025 16:55
@durran durran self-assigned this Feb 4, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 4, 2025
durran
durran approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note from our tech chat conversations, this is intentionally not providing any warning to users about needing to add the error listener to change streams.

@durran durran merged commit 1d0b2b4 into main Feb 5, 2025
26 of 30 checks passed
@durran durran deleted the test-santize-ee branch February 5, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran