MOBILE-4690 quiz: Check empty units on numerical question

moodlehq · Jan 17, 2025 · d524036 · d524036
1 parent 490847f
commit d524036
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/addons/qtype/numerical/services/handlers/numerical.ts b/src/addons/qtype/numerical/services/handlers/numerical.ts
@@ -216,12 +216,12 @@ export class AddonQtypeNumericalHandlerService implements CoreQuestionHandler {
             return Translate.instant('addon.qtype_numerical.invalidnumber');
         }
 
-        if (!question.parsedSettings) {
-            if (this.hasSeparateUnitField(question)) {
-                return Translate.instant('addon.qtype_numerical.unitnotselected');
-            }
+        if (this.hasSeparateUnitField(question) && !unit) {
+            return Translate.instant('addon.qtype_numerical.unitnotselected');
+        }
 
-            // We cannot know if the answer should contain units or not.
+        if (!question.parsedSettings) {
+            // We cannot check anything else without settings.
             return;
         }