Take holds into account for balance-consistency smoke test #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
reviewed
Jan 18, 2024
Co-authored-by: Éloïs <c@elo.tf>
|
LGTM, but I don't master the style of this part of the code, so we'd need an additional review from someone who knows better, maybe @timbrinded or @Agusrodri ? |
librelois
added
B0-silent
Coverage Report@@ Coverage Diff @@
## master elfedy-fix-smoke-bc +/- ##
======================================================
Coverage 80.94% 80.94% 0.00%
Files 287 287
Lines 94330 94330
======================================================
- Hits 76355 76354 -1
+ Misses 17975 17976 +1
|
Agusrodri
reviewed
Jan 19, 2024
Agusrodri
approved these changes
Jan 19, 2024
|
@elfedy can you please apply the new logic only if |
Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com>
@librelois done |
librelois
approved these changes
Jan 19, 2024
|
This test case is a nightmare (for perf reasons) but this change looks good to me. |
timbrinded
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
S300C100Smoke test fails with runtime 2700 due to some reserve amount being added tohold, so test needs to be adapted to that change by looking atholdsand adding them to the expected reserves.