-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orbiter notify_inactive_collator tests #2683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report@@ Coverage Diff @@
## master elfedy-test-orbiter +/- ##
======================================================
Coverage 73.68% 73.68% 0.00%
Files 232 232
Lines 72753 72753
======================================================
Hits 53603 53603
Misses 19150 19150
|
a83920a
to
a8e3c25
Compare
@elfedy can you also commit the script you used to regenerate the test identifiers? |
RomarQ
reviewed
Feb 26, 2024
elfedy
commented
Feb 26, 2024
e89f7e0
to
d03b5d5
Compare
Agusrodri
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some small suggestions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime code (so can't be audited)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a test flow that creates an orbiter pool and tests three things:
MaxOfflineRounds
MaxOfflineRounds
What important points reviewers should know?
Had to add
MoonbeamOrbitersConfig
to Moonbase's genesis config to setMinOrbiterDeposit
. The only way to set this value is via genesis or a migration.Is there something left for follow-up PRs?
alith
will always be the block producer on dev mode.AtStake
entry gets deleted onpay_one_collator_reward
.