Rename is_orbiter method to reference collator pool #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
added
B0-silent
elfedy
requested review from
links234,
RomarQ,
librelois,
ahmadkaouk and
Agusrodri
Coverage Report@@ Coverage Diff @@
## master elfedy-rename-is-orbiter +/- ##
===========================================================
Coverage 73.68% 73.68% 0.00%
Files 232 232
+ Lines 72750 72753 +3
===========================================================
Hits 53603 53603
+ Misses 19147 19150 +3
|
Agusrodri
approved these changes
Feb 26, 2024
RomarQ
approved these changes
Feb 26, 2024
ahmadkaouk
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Renames
is_orbitertois_collator_pool_with_active_orbiter. Previous name may cause confusion because it is not actually checking if an address is an orbiter for the round, but instead if the address is an orbiter pool with an active orbiter on that round.