Fast General Admin Track for opening HRMP channels #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B7-runtimenoteworthy
noandrea
changed the title
noandrea
changed the title
Coverage Report@@ Coverage Diff @@
## master noandrea-fast-admin-track-2 +/- ##
===============================================================
+ Coverage 72.46% 72.47% +0.01%
Files 229 229
+ Lines 70512 70523 +11
===============================================================
+ Hits 51094 51105 +11
Misses 19418 19418
|
noandrea
force-pushed
the
noandrea-fast-admin-track-2
branch
from
45ae0c9 to
61eb12e
Compare
noandrea
commented
Apr 8, 2024
librelois
approved these changes
Apr 8, 2024
Co-authored-by: Andrea Giacobino <no.andrea@gmail.com>
RomarQ
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Introduce a new origin
HrmpOpenOriginthat is allowed to open a Hrmp channel.On Moonbase this change limits the scope of opening the Hrmp channel to the Fast General Admin track, removing the possibility to make operation on the channel.
On Moonriver and Moonbeam this change adds the Fast General Admin track that allows to open a new Hrmp channel.
The Fast General Admin track is similar to the General Admin track but with less strict requirements
What important points reviewers should know?
Here is the forum post describing the change https://forum.moonbeam.network/t/new-track-for-opening-hrmp-xcm-channels/1669