Fix merge remote index + Pyright Issue Exp #577
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey π ,
I was trying to use
merge_index
with a remote folder following this structure :I was calling it like this:
merge_index("s3://my_bucket")
, but it kept failing. After some digging, I realized that it was attempting to downloads3//my_bucket/mds_1/index.json
(missing the ":").The fix involves simply adding a colon ':' here - it might not be obvious, as I had to move some code to add a test.
Thanks!
General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)