Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Node logging #2519

Closed
wants to merge 3 commits into from
Closed

Revert Node logging #2519

wants to merge 3 commits into from

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Nov 9, 2023

Description

Node logging has made a bunch of tests go flaky. Reverting these changes while we investigate the source of the test failures.

@tylerjw tylerjw requested review from sea-bass and sjahr November 9, 2023 16:34
@tylerjw tylerjw force-pushed the revert-logging branch 3 times, most recently from 883f687 to cb2d126 Compare November 9, 2023 17:38
This reverts commit 6a7b557.

Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (51dfbcc) 50.39% compared to head (85b2f69) 50.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
- Coverage   50.39%   50.35%   -0.03%     
==========================================
  Files         391      390       -1     
  Lines       31996    31961      -35     
==========================================
- Hits        16121    16092      -29     
+ Misses      15875    15869       -6     
Files Coverage Δ
...veit/occupancy_map_monitor/occupancy_map_monitor.h 33.34% <ø> (ø)
.../collision_plugin_loader/collision_plugin_loader.h 100.00% <ø> (ø)
...inematics_plugin_loader/kinematics_plugin_loader.h 100.00% <100.00%> (ø)
...eit/planning_scene_monitor/current_state_monitor.h 100.00% <ø> (ø)
...it/planning_scene_monitor/planning_scene_monitor.h 28.58% <ø> (ø)
...moveit/planning_scene_monitor/trajectory_monitor.h 75.00% <ø> (ø)
.../rdf_loader/include/moveit/rdf_loader/rdf_loader.h 100.00% <ø> (ø)
...ude/moveit/robot_model_loader/robot_model_loader.h 100.00% <ø> (ø)
...clude/moveit/robot_interaction/robot_interaction.h 0.00% <ø> (ø)
moveit_ros/moveit_servo/src/collision_monitor.cpp 87.28% <66.67%> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

mergify bot commented Nov 13, 2023

This pull request is in conflict. Could you fix it @tylerjw?

@tylerjw tylerjw closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant