Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveItPy Bug Fix: Perform Logging after RCLCPP Initialization #2676

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

peterdavidfagan
Copy link
Member

Description

There is currently a bug in the init method of the MoveItPy class as outlined here.

This change moves logging to after rclcpp::init has been called to prevent this bug.

Thanks to @TomCC7 for identifying this bug.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d962501) 50.74% compared to head (481ae90) 41.47%.
Report is 1 commits behind head on main.

Files Patch % Lines
...py/src/moveit/moveit_ros/moveit_cpp/moveit_cpp.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
- Coverage   50.74%   41.47%   -9.27%     
==========================================
  Files         392      690     +298     
  Lines       32553    56219   +23666     
  Branches        0     7286    +7286     
==========================================
+ Hits        16517    23312    +6795     
- Misses      16036    32744   +16708     
- Partials        0      163     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjw tylerjw merged commit ea98e73 into moveit:main Feb 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants