Remove plugins from export set #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
- Coverage 45.69% 45.63% -0.05%
==========================================
Files 714 714
Lines 62299 62297 -2
Branches 7533 7530 -3
==========================================
- Hits 28462 28425 -37
- Misses 33669 33705 +36
+ Partials 168 167 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
…oveit2 into pr-remove-plugin-from-export-set
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
sea-bass
added
backport-humble
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Remove plugins from export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * move more plugins to different export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * run pre-commit Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * remove plugins from moveit_kinematics export Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * do not link base interface to plugin in kinematics Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> --------- Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit b5eb4de) # Conflicts: # moveit_core/CMakeLists.txt # moveit_kinematics/CMakeLists.txt # moveit_kinematics/cached_ik_kinematics_plugin/CMakeLists.txt # moveit_ros/move_group/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Remove plugins from export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * move more plugins to different export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * run pre-commit Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * remove plugins from moveit_kinematics export Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * do not link base interface to plugin in kinematics Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> --------- Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit b5eb4de)
sjahr
pushed a commit
that referenced
this pull request
Jan 14, 2025
pac48
added a commit
to pac48/moveit2
that referenced
this pull request
Jan 29, 2025
* Remove plugins from export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * move more plugins to different export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * run pre-commit Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * remove plugins from moveit_kinematics export Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * do not link base interface to plugin in kinematics Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> --------- Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins that are intended to be loaded by classloader or pluginlib should not be in export sets that
ament_export_targetsis called on. This can cause plugins to fail to load.