-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move TrajectoryExecutionManager::clear() to private (backport #3226) #3237
Conversation
* move TrajectoryExecutionManager::clear() to private Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> --------- Signed-off-by: Dongya Jiang <1983534+patrickKXMD@users.noreply.github.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> (cherry picked from commit 3ec75ab) # Conflicts: # moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp # moveit_ros/move_group/src/default_capabilities/execute_trajectory_action_capability.cpp # moveit_ros/planning/plan_execution/src/plan_execution.cpp # moveit_ros/planning/trajectory_execution_manager/include/moveit/trajectory_execution_manager/trajectory_execution_manager.hpp
Cherry-pick of 3ec75ab has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3237 +/- ##
=======================================
Coverage 51.41% 51.41%
=======================================
Files 382 382
Lines 31893 31893
=======================================
Hits 16396 16396
Misses 15497 15497 ☔ View full report in Codecov by Sentry. |
Yes, I think so. I backported it to MoveIt1 as well. |
Description
previously discussed here #3198 (comment)
Checklist
This is an automatic backport of pull request #3226 done by [Mergify](https://mergify.com).