-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit convert from std::filesystem::path to std::string for Windows compatibility #3249
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
==========================================
- Coverage 45.65% 45.65% -0.00%
==========================================
Files 714 714
Lines 62298 62297 -1
Branches 7532 7531 -1
==========================================
- Hits 28437 28433 -4
- Misses 33695 33697 +2
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the clang-tidy check was failing because of the new generate_parameter_library version putting headers elsewhere. Deleted all the repo's build caches and will see how it goes. |
Description
On Linux and macOS
std::filesystem::path
is implicitly convertible tostd::string
, while on Windows it is convertible tostd::wstring
, see https://en.cppreference.com/w/cpp/filesystem/path and https://stackoverflow.com/questions/57377349/implicit-conversion-between-stdfilesystempath-and-stdstring-should-it-hap . If we want to convertstd::filesystem::path
tostd::string
in a Windows-compatible way, it is then necessary to explicitly call the.string()
method.Fix part of #2391 .
Checklist