Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit convert from std::filesystem::path to std::string for Windows compatibility #3249

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 19, 2025

Description

On Linux and macOS std::filesystem::path is implicitly convertible to std::string, while on Windows it is convertible to std::wstring, see https://en.cppreference.com/w/cpp/filesystem/path and https://stackoverflow.com/questions/57377349/implicit-conversion-between-stdfilesystempath-and-stdstring-should-it-hap . If we want to convert std::filesystem::path to std::string in a Windows-compatible way, it is then necessary to explicitly call the .string() method.

Fix part of #2391 .

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (415a4a2) to head (ceff78c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...up_core_plugins/src/configuration_files_widget.cpp 0.00% 4 Missing ⚠️
...eit_setup_core_plugins/src/start_screen_widget.cpp 0.00% 3 Missing ⚠️
.../moveit_setup_assistant/src/collisions_updater.cpp 0.00% 2 Missing ⚠️
...sistant/moveit_setup_framework/src/urdf_config.cpp 71.43% 2 Missing ⚠️
...eit_setup_assistant/src/setup_assistant_widget.cpp 0.00% 1 Missing ⚠️
.../moveit_setup_core_plugins/configuration_files.hpp 0.00% 1 Missing ⚠️
...ant/moveit_setup_core_plugins/src/start_screen.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3249      +/-   ##
==========================================
- Coverage   45.65%   45.65%   -0.00%     
==========================================
  Files         714      714              
  Lines       62298    62297       -1     
  Branches     7532     7531       -1     
==========================================
- Hits        28437    28433       -4     
- Misses      33695    33697       +2     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Jan 20, 2025
@sea-bass sea-bass added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@sea-bass sea-bass added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@sea-bass sea-bass added this pull request to the merge queue Jan 20, 2025
@sea-bass
Copy link
Contributor

I think the clang-tidy check was failing because of the new generate_parameter_library version putting headers elsewhere. Deleted all the repo's build caches and will see how it goes.

Merged via the queue into moveit:main with commit 2b9173b Jan 20, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Jan 20, 2025
…s compatibility (#3249)

(cherry picked from commit 2b9173b)

# Conflicts:
#	moveit_setup_assistant/moveit_setup_assistant/src/setup_assistant_widget.cpp
#	moveit_setup_assistant/moveit_setup_framework/src/urdf_config.cpp
mergify bot pushed a commit that referenced this pull request Jan 20, 2025
sea-bass pushed a commit that referenced this pull request Jan 20, 2025
…s compatibility (#3249) (#3254)

(cherry picked from commit 2b9173b)

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
sea-bass pushed a commit that referenced this pull request Jan 20, 2025
…s compatibility (backport #3249) (#3253)

(cherry picked from commit 2b9173b)

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants