Support including the names of other attached objects in touch_link (backport #3276)
#3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
sea-bass
approved these changes
Jan 31, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3287 +/- ##
==========================================
- Coverage 51.41% 51.40% -0.01%
==========================================
Files 382 382
Lines 31894 31899 +5
==========================================
- Hits 16395 16393 -2
- Misses 15499 15506 +7 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287) ... for joint-specific start tolerances for TrajectoryExecutionManager Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> * Port to moveit2 * Allow joints_allowed_start_tolerance to be updated dynamically * Apply formatting * Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints --------- Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287) ... for joint-specific start tolerances for TrajectoryExecutionManager Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> * Port to moveit2 * Allow joints_allowed_start_tolerance to be updated dynamically * Apply formatting * Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints --------- Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> (cherry picked from commit 9922704)
sea-bass
pushed a commit
that referenced
this pull request
Feb 6, 2025
) * Add joints_allowed_start_tolerance parameter (moveit/moveit#3287) ... for joint-specific start tolerances for TrajectoryExecutionManager Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> * Port to moveit2 * Allow joints_allowed_start_tolerance to be updated dynamically * Apply formatting * Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints --------- Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> (cherry picked from commit 9922704) Co-authored-by: Daniel García López <d.garcialopez@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3275. See that RFE for motivation and discussion of pros/cons and alternative approaches.
Checklist
This is an automatic backport of pull request #3276 done by [Mergify](https://mergify.com).