Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support including the names of other attached objects in touch_link (backport #3276) #3288

Open
wants to merge 1 commit into
base: jazzy
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 31, 2025

Description

Fixes #3275. See that RFE for motivation and discussion of pros/cons and alternative approaches.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3276 done by [Mergify](https://mergify.com).

…#3276)

* Support including the names of other attached objects in `touch_link`

Fixes #3275

* Add a comment; add {} for readability

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit 75fb28b)
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (73c386f) to head (8b3f895).

Files with missing lines Patch % Lines
...e/collision_detection_fcl/src/collision_common.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3288      +/-   ##
==========================================
+ Coverage   44.12%   44.12%   +0.01%     
==========================================
  Files         700      700              
  Lines       61662    61667       +5     
  Branches     7471     7473       +2     
==========================================
+ Hits        27202    27207       +5     
- Misses      34292    34293       +1     
+ Partials      168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants