Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ros2ControlManager chained controller logic (backport #3301) #3306

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 4, 2025

Description

It looks like this PR might have broken the chained controller management logic.
Previously, claimed_interfaces were being used to determine which joints each controller was associated with, but now required_command_interfaces is used. That seems reasonable, but it was not updated everywhere. Specifically, there is some logic to handle ros2_control's chained controllers that was not updated. This PR fixes that issue.


This is an automatic backport of pull request #3301 done by [Mergify](https://mergify.com).

Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
(cherry picked from commit cf1d3e0)
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (ed91e7d) to head (1c35707).
Report is 1 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #3306   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         382      382           
  Lines       31899    31899           
=======================================
  Hits        16394    16394           
  Misses      15505    15505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 77dde32 into humble Feb 4, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3301 branch February 4, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants