Merge pull request #144 from movio/remove-polling-client-keep-alive

Remove service polling client keep alive

client.go

@@ -41,6 +41,24 @@ func NewClient(opts ...ClientOpt) *GraphQLClient {
 	return c
 }
 
+func NewClientWithoutKeepAlive(opts ...ClientOpt) *GraphQLClient {
+	transport := http.DefaultTransport.(*http.Transport).Clone()
+	transport.DisableKeepAlives = true
+	c := &GraphQLClient{
+		HTTPClient: &http.Client{
+			Timeout:   5 * time.Second,
+			Transport: transport,
+		},
+		MaxResponseSize: 1024 * 1024,
+	}
+
+	for _, opt := range opts {
+		opt(c)
+	}
+
+	return c
+}
+
 // WithHTTPClient sets a custom HTTP client to be used when making downstream queries.
 func WithHTTPClient(client *http.Client) ClientOpt {
 	return func(s *GraphQLClient) {

client_test.go

@@ -36,6 +36,23 @@ func TestGraphqlClient(t *testing.T) {
 		assert.Equal(t, "value", res.Root.Test)
 	})
 
+	t.Run("without keep-alive", func(t *testing.T) {
+		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			require.Equal(t, "close", r.Header.Get("Connection"))
+			w.Write([]byte(`{
+				"data": {
+					"root": {
+						"test": "value"
+					}
+				}
+			}`))
+		}))
+
+		c := NewClientWithoutKeepAlive()
+		err := c.Request(context.Background(), srv.URL, &Request{}, nil)
+		assert.NoError(t, err)
+	})
+
 	t.Run("with http client", func(t *testing.T) {
 		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			cookie, err := r.Cookie("test_cookie")

introspection.go

@@ -24,7 +24,7 @@ type Service struct {
 func NewService(serviceURL string) *Service {
 	s := &Service{
 		ServiceURL: serviceURL,
-		client:     NewClient(WithUserAgent(GenerateUserAgent("update"))),
+		client:     NewClientWithoutKeepAlive(WithUserAgent(GenerateUserAgent("update"))),
 	}
 	return s
 }