Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the extension the ability to get the parent process info #10216

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Jan 23, 2025

Description

Based on top of: #10196

Reference

Right now we only check if the Split-Tunnel List includes Firefox* - but if i.e you have nightly excluded and use the extension on ESR, we still block out.
Given that Firefox will spawn the nativemessaging process, we can ask it to check it's parent executable.
This allows the extension to check if the Firefox used is excluded or not.

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Same caveat as the other PR - would love a second reviewer on this, as I'm less familiar with this.

Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from basti/nativeMessaging to main February 4, 2025 17:05
@strseb strseb enabled auto-merge (squash) February 12, 2025 17:18
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label Feb 12, 2025
@strseb strseb merged commit 56365af into main Feb 12, 2025
118 of 119 checks passed
@strseb strseb deleted the basti/procinfo branch February 12, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants