Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example of how to use Stencils #78

Merged
merged 2 commits into from
May 14, 2024

Conversation

dmitrikozlov
Copy link

The example shows how to use Stencils to avoid repetitive compilations of the same scripts. It addresses issue #63 and demonstrates API such as:

Copy link
Contributor

@arai-a arai-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding example for Stencil!
I'm sorry for the long delay.

examples/stencils.cpp Outdated Show resolved Hide resolved
examples/stencils.cpp Outdated Show resolved Hide resolved
examples/README.md Show resolved Hide resolved
examples/stencils.cpp Outdated Show resolved Hide resolved
Removed setNonSyntacticScope and JS::CompilationStorage. Set dependency('mozjs-124a1')
@dmitrikozlov
Copy link
Author

I've completed the changes based on the feedback. Thanks.

Copy link
Contributor

@arai-a arai-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you!

@dmitrikozlov
Copy link
Author

Do I need to do something else?

@arai-a
Copy link
Contributor

arai-a commented May 14, 2024

no, I've asked for merge.
Will be merged shortly.

@dmitrikozlov
Copy link
Author

Thank you for your help!

@ptomato ptomato merged commit 8889a65 into mozilla-spidermonkey:next May 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants