Add firefox gaming landing page (Fixes #15920) #15947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
commented
Jan 30, 2025
Comment on lines
+15
to
+16
| {% set win_custom_download_id = 'partner-firefox-release-smi-smi-002-stub' %} | ||
| {% set mac_custom_download_id = 'partner-firefox-release-smi-smi-002-latest' %} |
There was a problem hiding this comment.
Note: these builds are still 404 for the time being.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15947 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 160 160
Lines 8396 8396
=======================================
Hits 6681 6681
Misses 1715 1715 ☔ View full report in Codecov by Sentry. |
alexgibson
force-pushed
the
landing-gaming
branch
6 times, most recently
from
edbb29d to
f05bb42
Compare
alexgibson
force-pushed
the
landing-gaming
branch
from
f05bb42 to
d7b8708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Add UK influencer campaign phase 2 page (gaming).
Significant changes and points to review
This is a greatly simplified version of the
/firefox/new/page with updated copy and imagery. The original CSS was pretty complex, so I tried to simplify it by replacing some of the custom layouts with standard protocol layouts (which I'm guessing didn't exist at that time). An extra pair of eyes to check that there's nothing else left in that's no longer needed would be appreciated.Issue / Bugzilla link
#15920
Testing
http://localhost:8000/en-GB/firefox/landing/gaming/