-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace xitter links with Bluesky (#15988) #15989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions for consistency:
@@ -66,7 +66,7 @@ <h2 class="moz24-footer-label" data-testid="footer-heading-developers"> | |||
<div class="moz24-footer-refresh-social-wrapper"> | |||
<h2 class="moz24-footer-heading-social">{{ ftl('footer-refresh-follow-mozilla') }}</h2> | |||
<ul class="moz24-footer-links-social"> | |||
<li><a class="twitter" href="{{ mozilla_twitter_url() }}" data-link-position="footer" data-link-text="Twitter (@mozilla)">{{ ftl('footer-refresh-x-formerly-twitter', fallback='footer-twitter') }}<span> (@mozilla)</span></a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can both the helpers
bedrock/bedrock/mozorg/templatetags/misc.py
Lines 420 to 425 in 6aafa46
def mozilla_twitter_url(ctx): | |
"""Output a link to Twitter taking locales into account. | |
Uses the locale from the current request. Checks to see if we have | |
a Twitter account that match this locale, returns the localized account | |
url or falls back to the US account url if not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I was checking if we wanted to repurpose for Bluesky, but will remove as it seems we don't have localised account there yet
bedrock/base/templates/includes/protocol/footer/footer-refresh.html
Outdated
Show resolved
Hide resolved
l10n/en/footer-refresh.ftl
Outdated
@@ -8,8 +8,7 @@ footer-refresh-advertise = Advertise with { -brand-name-mozilla } | |||
footer-refresh-firefox-release-notes = { -brand-name-firefox } Release Notes | |||
footer-refresh-mdn = MDN | |||
footer-refresh-follow-mozilla = Follow @{ -brand-name-mozilla } | |||
footer-refresh-x = X | |||
footer-refresh-x-formerly-twitter = X (formerly Twitter) | |||
footer-refresh-bluesky = Bluesky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it's here "Bluesky" literally, sometimes {-brand-name-bluesky} reference …
IIUC third party brands should no longer be added to the brand terms, so probably can be used spelled out fully in every single string(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it's here "Bluesky" literally, sometimes {-brand-name-bluesky} reference
this was a miss on my part, I meant to use the brand name ref consistently, still checking on the brand term standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed internally, we're not going to include the 3rd party brand in FTL files (unless it's part of a larger sentence, in which case we should use a comment to indicate the words that should not be translated), will put directly in HTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: I see some Twitter links for the Nightly templates, ex: /Users/jingwen/Documents/projects/bedrock/bedrock/firefox/templates/firefox/nightly/firstrun.it.html
<a href="https://twitter.com/mozilla_fr/">@mozilla_fr sur Twitter</a>
, should they be removed too?
@wen-2018 it's a good question. I've asked internally. I think they should be removed eventually but question whether it should be as part of this PR or a separate one to follow up on the less visible links (and share urls). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes LGTM! r+
Per the internal discussions, other clean ups can be in a separate PR
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label.One-line summary
Replaces xitter links with bluesky links and adds bluesky icons
Significant changes and points to review
Issue / Bugzilla link
#15988
Testing