Skip to content

Commit

Permalink
ci(check.yml): add sleep i.e. client wait for server (#1765)
Browse files Browse the repository at this point in the history
Windows CI oftentimes fails with:

```
 0s  0ms INFO H3 Client connecting: [::]:65093 -> [::1]:4433
Error: IoError(Os { code: 10054, kind: ConnectionReset, message: "An existing connection was forcibly closed by the remote host." })
0s  0ms INFO Server waiting for connection on: [::1]:4433
0s  0ms INFO Server waiting for connection on: 127.0.0.1:4433
```

https://github.com/mozilla/neqo/actions/runs/8374577016/job/22930136500?pr=1692

This suggests that the client connects to the server before the server is ready
to accept connections.

This commit adds a sleep, thus giving the server time to start up.

Tracked in #1759.

Sleep was previously introduced in #1713 but
later removed in #1717
  • Loading branch information
mxinden authored Mar 21, 2024
1 parent 7028479 commit e2f9369
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ jobs:
cargo +${{ matrix.rust-toolchain }} build $BUILD_TYPE --bin neqo-client --bin neqo-server
"target/$BUILD_DIR/neqo-server" "$HOST:4433" &
PID=$!
# Give the server time to start.
sleep 1
"target/$BUILD_DIR/neqo-client" --output-dir . "https://$HOST:4433/$SIZE"
kill $PID
[ "$(wc -c <"$SIZE")" -eq "$SIZE" ] || exit 1
Expand Down

0 comments on commit e2f9369

Please sign in to comment.