-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend Frame::Padding
with length
#1762
Conversation
This is preparation of qlog supporting the logging of runs of padding frames via `payload_length`, instead of each one individually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Frame::Padding
with a length
fieldFrame::Padding
with length
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
=======================================
Coverage 92.97% 92.98%
=======================================
Files 119 119
Lines 37253 37246 -7
=======================================
- Hits 34637 34633 -4
+ Misses 2616 2613 -3 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 32ef2c3.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is preparation of qlog supporting the logging of runs of padding frames via
payload_length
, instead of each one individually.Needs cloudflare/quiche#1745 (eventually).