Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend Frame::Padding with length #1762

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Mar 20, 2024

This is preparation of qlog supporting the logging of runs of padding frames via payload_length, instead of each one individually.

Needs cloudflare/quiche#1745 (eventually).

This is preparation of qlog supporting the logging of runs of padding
frames via `payload_length`, instead of each one individually.
@larseggert larseggert marked this pull request as draft March 20, 2024 01:39
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

neqo-transport/src/frame.rs Outdated Show resolved Hide resolved
neqo-transport/src/frame.rs Outdated Show resolved Hide resolved
neqo-transport/src/packet/mod.rs Show resolved Hide resolved
neqo-transport/src/qlog.rs Outdated Show resolved Hide resolved
@larseggert larseggert changed the title feat: Extend Frame::Padding with a length field feat: Extend Frame::Padding with length Mar 20, 2024
@larseggert larseggert marked this pull request as ready for review March 20, 2024 05:41
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 93.04813% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 92.98%. Comparing base (7028479) to head (aa71d49).

Files Patch % Lines
neqo-transport/src/frame.rs 71.42% 8 Missing ⚠️
neqo-transport/src/qlog.rs 98.02% 3 Missing ⚠️
neqo-transport/src/connection/dump.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   92.97%   92.98%           
=======================================
  Files         119      119           
  Lines       37253    37246    -7     
=======================================
- Hits        34637    34633    -4     
+ Misses       2616     2613    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to 32ef2c3.

  • coalesce_acked_from_zero 1+1 entries
    time: [196.70 ns 197.21 ns 197.77 ns]
    change: [-0.9743% -0.6245% -0.2430%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 3+1 entries
    time: [237.99 ns 240.23 ns 244.49 ns]
    change: [-2.8540% -2.1868% -1.3377%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 10+1 entries
    time: [237.43 ns 238.00 ns 238.74 ns]
    change: [-3.5165% -2.5301% -1.7019%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 1000+1 entries
    time: [219.82 ns 220.05 ns 220.33 ns]
    change: [-2.8017% -2.0773% -1.3776%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • RxStreamOrderer::inbound_frame()
    time: [120.21 ms 120.29 ms 120.37 ms]
    change: [-0.0926% +0.0084% +0.1109%] (p = 0.88 > 0.05)
    No change in performance detected.

  • transfer/Run multiple transfers with varying seeds
    time: [116.88 ms 117.15 ms 117.41 ms]
    thrpt: [34.069 MiB/s 34.145 MiB/s 34.222 MiB/s]
    change:
    time: [-1.0057% -0.6906% -0.3471%] (p = 0.00 < 0.05)
    thrpt: [+0.3483% +0.6954% +1.0159%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [117.25 ms 117.45 ms 117.67 ms]
    thrpt: [33.993 MiB/s 34.057 MiB/s 34.116 MiB/s]
    change:
    time: [-0.9901% -0.7597% -0.5360%] (p = 0.00 < 0.05)
    thrpt: [+0.5389% +0.7655% +1.0000%]
    Change within noise threshold.

⬇️ Download logs

Copy link
Collaborator

@KershawChang KershawChang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@larseggert larseggert added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@larseggert larseggert added this pull request to the merge queue Mar 21, 2024
Merged via the queue into mozilla:main with commit 56f53bb Mar 21, 2024
15 checks passed
@larseggert larseggert deleted the feat-pad-len branch March 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants