chore: Make the TLS epoch an enum type
#2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 95.28% 95.28% -0.01%
==========================================
Files 114 115 +1
Lines 37111 37135 +24
Branches 37111 37135 +24
==========================================
+ Hits 35363 35385 +22
- Misses 1742 1746 +4
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to cb058cb. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9734cf2. decode 4096 bytes, mask ff: 💔 Performance has regressed. time: [12.314 µs 12.349 µs 12.390 µs]
change: [+13.020% +13.429% +13.845%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.8325 ms 2.8401 ms 2.8494 ms]
change: [-9.7816% -9.3962% -9.0079%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: 💔 Performance has regressed. time: [20.854 µs 20.918 µs 20.990 µs]
change: [+17.761% +18.208% +18.616%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.5423 ms 4.5537 ms 4.5668 ms]
change: [-16.227% -15.925% -15.620%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💔 Performance has regressed. time: [8.2830 µs 8.3300 µs 8.3852 µs]
change: [+25.596% +26.274% +26.945%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💚 Performance has improved. time: [1.5874 ms 1.5929 ms 1.5997 ms]
change: [-9.7066% -9.4028% -9.0224%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.225 ns 91.503 ns 91.787 ns]
change: [-0.2906% +0.2458% +0.7534%] (p = 0.38 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.71 ns 110.06 ns 110.44 ns]
change: [-0.0507% +0.3499% +0.7906%] (p = 0.11 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.49 ns 109.96 ns 110.52 ns]
change: [-0.0519% +0.4522% +0.9648%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.489 ns 93.674 ns 93.876 ns]
change: [-1.0446% +0.0859% +1.2141%] (p = 0.89 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.25 ms 112.30 ms 112.36 ms]
change: [+0.6482% +0.7128% +0.7750%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2620 µs 5.4723 µs 5.7101 µs]
change: [-2.5933% +0.5063% +3.6915%] (p = 0.75 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [38.387 ms 38.482 ms 38.583 ms]
change: [+4.1797% +4.4955% +4.8231%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [38.738 ms 38.819 ms 38.912 ms]
change: [+6.0303% +6.3357% +6.6457%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [38.615 ms 38.694 ms 38.778 ms]
change: [+5.7123% +6.0040% +6.2966%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [38.707 ms 38.776 ms 38.850 ms]
change: [+5.8883% +6.1466% +6.4174%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [854.38 ms 864.50 ms 874.78 ms]
thrpt: [114.31 MiB/s 115.67 MiB/s 117.04 MiB/s]
change:
time: [-1.3192% +0.2439% +1.8754%] (p = 0.77 > 0.05)
thrpt: [-1.8409% -0.2433% +1.3368%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [318.33 ms 321.61 ms 324.87 ms]
thrpt: [30.782 Kelem/s 31.093 Kelem/s 31.414 Kelem/s]
change:
time: [-1.0163% +0.5062% +2.1012%] (p = 0.52 > 0.05)
thrpt: [-2.0580% -0.5037% +1.0268%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.378 ms 25.532 ms 25.687 ms]
thrpt: [38.930 elem/s 39.167 elem/s 39.404 elem/s]
change:
time: [-1.0509% -0.2055% +0.7036%] (p = 0.65 > 0.05)
thrpt: [-0.6987% +0.2059% +1.0620%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.7671 s 1.7869 s 1.8068 s]
thrpt: [55.346 MiB/s 55.962 MiB/s 56.590 MiB/s]
change:
time: [-8.3708% -6.9650% -5.5595%] (p = 0.00 < 0.05)
thrpt: [+5.8868% +7.4865% +9.1356%]
Client/server transfer resultsPerformance differences relative to 9734cf2. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
mxinden
reviewed
Jan 10, 2025
mxinden
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good to me.
Let's give Martin a chance to comment on #2320 (comment)
Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace
CryptoSpacewith it.