fix(transport): handle out-of-order frame on remote init stream #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 7f8136e. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
force-pushed
the
local-illegal
branch
from
e83fccb to
cea9872
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 114 114
Lines 36850 36856 +6
Branches 36850 36856 +6
==========================================
+ Hits 35117 35122 +5
- Misses 1727 1728 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
larseggert
approved these changes
Jan 14, 2025
mxinden
force-pushed
the
local-illegal
branch
from
cea9872 to
cc68683
Compare
mozilla#2269 made a "stream control or data frame for a stream that is ours to initiate but we haven't yet" illegal. ``` rust let existed = !stream_id.is_remote_initiated(self.role) && self.local_stream_limits[stream_id.stream_type()].used() > stream_id.index(); ``` Problem is, when `is_remote_initiated` is `true`, then `existed` is `false`, which leads to a false positive for remote initiated streams.
mxinden
force-pushed
the
local-illegal
branch
from
cc68683 to
78cf868
Compare
mxinden
changed the title
mxinden
changed the title
|
Updated PR description and added a unit test. @larseggert can you take another look? |
larseggert
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2269 made a "stream control or data frame for a stream that is ours to initiate but we haven't yet" illegal.
neqo/neqo-transport/src/streams.rs
Lines 409 to 424 in 7bbf900
Given a remote initiated stream that has been closed and forgotten since. Say that the local node receives an out-of-order frame on said forgotten stream. In such scenario:
stream_id.is_remote_initiatedistrueexistedisfalsess.is_none()andrs.is_none()istruess.is_none() && rs.is_none() && !existedistrueobtain_streamfalsely returnsErr(Error::StreamStateError);This commit fixes the above issue, only returning
Err(Error::StreamStateError);on locally initiated streams.