chore: Factor out packet logging #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `output_path` and `input_path` are getting long, and there is a lot of redundancy between the calls to `dump` and `qlog`.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.02%
==========================================
Files 114 114
Lines 36868 36869 +1
Branches 36868 36869 +1
==========================================
- Hits 35146 35142 -4
- Misses 1718 1721 +3
- Partials 4 6 +2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 379722c. decode 4096 bytes, mask ff: No change in performance detected. time: [11.842 µs 11.874 µs 11.913 µs]
change: [-1.0257% -0.3394% +0.2150%] (p = 0.32 > 0.05)
decode 1048576 bytes, mask ff: Change within noise threshold. time: [2.8857 ms 2.9051 ms 2.9375 ms]
change: [-1.7783% -0.9797% +0.1794%] (p = 0.04 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.751 µs 19.794 µs 19.844 µs]
change: [-0.7755% -0.3633% +0.0027%] (p = 0.07 > 0.05)
decode 1048576 bytes, mask 7f: Change within noise threshold. time: [5.0756 ms 5.0986 ms 5.1321 ms]
change: [+0.1739% +0.7222% +1.4896%] (p = 0.02 < 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.8973 µs 6.9228 µs 6.9553 µs]
change: [-1.7430% -0.5042% +0.3699%] (p = 0.42 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4156 ms 1.4212 ms 1.4281 ms]
change: [-0.3678% +0.2176% +0.8099%] (p = 0.47 > 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.418 ns 99.762 ns 100.11 ns]
change: [+0.6515% +1.0636% +1.5500%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.91 ns 118.33 ns 118.76 ns]
change: [-0.6676% +0.4076% +1.1736%] (p = 0.46 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.07 ns 117.42 ns 117.89 ns]
change: [+0.0660% +1.1616% +2.8324%] (p = 0.12 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.421 ns 98.606 ns 98.811 ns]
change: [+0.0273% +1.2609% +2.4845%] (p = 0.03 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.64 ms 111.77 ms 111.99 ms]
change: [+0.2833% +0.4189% +0.6468%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.3813 µs 5.4697 µs 5.5567 µs]
change: [-15.816% -4.7378% +3.0213%] (p = 0.58 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [41.453 ms 41.528 ms 41.603 ms]
change: [-4.5507% -4.3007% -4.0545%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [41.529 ms 41.617 ms 41.714 ms]
change: [-4.0958% -3.7875% -3.4786%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [40.938 ms 41.019 ms 41.099 ms]
change: [-5.3732% -5.0927% -4.8264%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [41.505 ms 41.574 ms 41.644 ms]
change: [-5.1437% -4.9078% -4.6773%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [895.11 ms 907.57 ms 920.14 ms]
thrpt: [108.68 MiB/s 110.18 MiB/s 111.72 MiB/s]
change:
time: [-3.3071% -1.6969% +0.1013%] (p = 0.04 < 0.05)
thrpt: [-0.1012% +1.7262% +3.4202%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [315.02 ms 317.27 ms 319.59 ms]
thrpt: [31.290 Kelem/s 31.519 Kelem/s 31.745 Kelem/s]
change:
time: [-2.0966% -1.1148% -0.1641%] (p = 0.03 < 0.05)
thrpt: [+0.1644% +1.1274% +2.1415%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold. time: [34.632 ms 34.830 ms 35.051 ms]
thrpt: [28.530 elem/s 28.711 elem/s 28.875 elem/s]
change:
time: [+0.3558% +1.1208% +1.9007%] (p = 0.00 < 0.05)
thrpt: [-1.8652% -1.1084% -0.3546%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5526 s 1.5688 s 1.5849 s]
thrpt: [63.096 MiB/s 63.745 MiB/s 64.410 MiB/s]
change:
time: [-9.6646% -8.2581% -6.7924%] (p = 0.00 < 0.05)
thrpt: [+7.2874% +9.0014% +10.699%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
martinthomson
approved these changes
Jan 30, 2025
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
output_pathandinput_pathare getting long, and there is a lot of redundancy between the calls todumpandqlog.