chore: clippy +nightly --fix
#2398
Merged
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.02%
==========================================
Files 114 114
Lines 36868 36868
Branches 36868 36868
==========================================
- Hits 35146 35141 -5
- Misses 1718 1721 +3
- Partials 4 6 +2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 379722c. decode 4096 bytes, mask ff: No change in performance detected. time: [11.849 µs 11.887 µs 11.931 µs]
change: [-0.9833% -0.2770% +0.2433%] (p = 0.43 > 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.8818 ms 2.8890 ms 2.8977 ms]
change: [-1.9791% -1.5276% -1.0704%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: Change within noise threshold. time: [19.746 µs 19.791 µs 19.842 µs]
change: [-0.8003% -0.3957% -0.0268%] (p = 0.04 < 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0658 ms 5.0772 ms 5.0901 ms]
change: [-0.0572% +0.2985% +0.6630%] (p = 0.11 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.9061 µs 6.9392 µs 6.9774 µs]
change: [-1.7084% -0.5078% +0.3020%] (p = 0.41 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4139 ms 1.4194 ms 1.4262 ms]
change: [-0.4791% +0.0929% +0.6839%] (p = 0.77 > 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.015 ns 99.404 ns 99.810 ns]
change: [+0.1291% +0.6317% +1.1872%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.81 ns 117.14 ns 117.49 ns]
change: [-1.6277% -0.5987% +0.0850%] (p = 0.20 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.44 ns 116.83 ns 117.33 ns]
change: [-0.5291% +0.3098% +1.3654%] (p = 0.55 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.159 ns 97.271 ns 97.401 ns]
change: [-1.2634% -0.1961% +0.8169%] (p = 0.74 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.47 ms 111.52 ms 111.57 ms]
change: [+0.1159% +0.1902% +0.2589%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4195 µs 5.5391 µs 5.6781 µs]
change: [-14.887% -3.2989% +4.9480%] (p = 0.71 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [41.772 ms 41.855 ms 41.940 ms]
change: [-3.8231% -3.5468% -3.2937%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [41.503 ms 41.587 ms 41.676 ms]
change: [-4.1656% -3.8589% -3.5631%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [41.217 ms 41.308 ms 41.409 ms]
change: [-4.7240% -4.4237% -4.1217%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [41.687 ms 41.769 ms 41.862 ms]
change: [-4.7273% -4.4620% -4.2182%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [885.60 ms 895.48 ms 905.63 ms]
thrpt: [110.42 MiB/s 111.67 MiB/s 112.92 MiB/s]
change:
time: [-4.4225% -3.0061% -1.4990%] (p = 0.00 < 0.05)
thrpt: [+1.5218% +3.0993% +4.6272%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [313.96 ms 315.92 ms 317.94 ms]
thrpt: [31.452 Kelem/s 31.654 Kelem/s 31.852 Kelem/s]
change:
time: [-2.4454% -1.5376% -0.6213%] (p = 0.00 < 0.05)
thrpt: [+0.6252% +1.5616% +2.5067%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.200 ms 34.376 ms 34.570 ms]
thrpt: [28.927 elem/s 29.090 elem/s 29.239 elem/s]
change:
time: [-0.8859% -0.1967% +0.5560%] (p = 0.59 > 0.05)
thrpt: [-0.5529% +0.1971% +0.8939%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5969 s 1.6148 s 1.6327 s]
thrpt: [61.250 MiB/s 61.929 MiB/s 62.622 MiB/s]
change:
time: [-7.0362% -5.5681% -4.0168%] (p = 0.00 < 0.05)
thrpt: [+4.1849% +5.8964% +7.5687%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.