ci: Usemold linker on Linux, lld on Windows
#2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's see if this speeds things up more.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 114 114
Lines 36903 36903
Branches 36903 36903
=======================================
Hits 35155 35155
Misses 1742 1742
Partials 6 6 ☔ View full report in Codecov by Sentry. |
larseggert
changed the title
mold linker on linuxmold linker on Linux, lld on Windows
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 6cdbc0c. decode 4096 bytes, mask ff: Change within noise threshold. time: [11.794 µs 11.853 µs 11.937 µs]
change: [-1.3283% -0.7899% -0.3079%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.9032 ms 2.9128 ms 2.9241 ms]
change: [-5.9187% -5.4857% -5.0739%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: Change within noise threshold. time: [19.689 µs 19.742 µs 19.803 µs]
change: [-1.0472% -0.6529% -0.1907%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.7116 ms 4.7226 ms 4.7343 ms]
change: [-8.9848% -8.6846% -8.3794%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💚 Performance has improved. time: [6.2149 µs 6.2393 µs 6.2717 µs]
change: [-10.466% -10.016% -9.5795%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [2.1137 ms 2.1206 ms 2.1289 ms]
change: [+20.191% +20.589% +20.983%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [93.399 ns 93.742 ns 94.083 ns]
change: [+0.1097% +0.5462% +0.9861%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.92 ns 111.30 ns 111.70 ns]
change: [+0.0402% +1.0033% +2.3482%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [110.36 ns 110.85 ns 111.43 ns]
change: [-0.0671% +0.4468% +0.9374%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [92.440 ns 92.559 ns 92.696 ns]
change: [-0.2575% +0.6415% +1.5727%] (p = 0.19 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.90 ms 112.03 ms 112.24 ms]
change: [+0.0023% +0.1362% +0.3146%] (p = 0.11 > 0.05)
SentPackets::take_ranges: :broken_heart: Performance has regressed. time: [5.2786 µs 5.4960 µs 5.7367 µs]
change: [+2.3544% +5.2818% +8.3508%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [40.730 ms 40.809 ms 40.888 ms]
change: [+0.2302% +0.4795% +0.7333%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [40.524 ms 40.599 ms 40.673 ms]
change: [+0.0824% +0.3267% +0.5819%] (p = 0.01 < 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [40.421 ms 40.501 ms 40.581 ms]
change: [-0.4969% -0.1991% +0.0903%] (p = 0.20 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [40.994 ms 41.063 ms 41.142 ms]
change: [+0.9079% +1.1622% +1.4193%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [836.19 ms 844.79 ms 853.66 ms]
thrpt: [117.14 MiB/s 118.37 MiB/s 119.59 MiB/s]
change:
time: [-6.9105% -5.3637% -3.8528%] (p = 0.00 < 0.05)
thrpt: [+4.0072% +5.6677% +7.4235%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [310.50 ms 312.39 ms 314.30 ms]
thrpt: [31.817 Kelem/s 32.011 Kelem/s 32.206 Kelem/s]
change:
time: [-2.3275% -1.4559% -0.6035%] (p = 0.00 < 0.05)
thrpt: [+0.6071% +1.4774% +2.3829%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.215 ms 34.380 ms 34.561 ms]
thrpt: [28.934 elem/s 29.086 elem/s 29.227 elem/s]
change:
time: [-0.6235% +0.1179% +0.8841%] (p = 0.75 > 0.05)
thrpt: [-0.8764% -0.1178% +0.6274%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5662 s 1.5797 s 1.5930 s]
thrpt: [62.773 MiB/s 63.303 MiB/s 63.848 MiB/s]
change:
time: [-3.8944% -2.6004% -1.3208%] (p = 0.00 < 0.05)
thrpt: [+1.3385% +2.6699% +4.0522%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this speeds things up more.