Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lukemathwalker/cargo-chef from 8d7418b to ca7d16d in /qns #2407

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 3, 2025

Bumps lukemathwalker/cargo-chef from 8d7418b to ca7d16d.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps lukemathwalker/cargo-chef from `8d7418b` to `ca7d16d`.

---
updated-dependencies:
- dependency-name: lukemathwalker/cargo-chef
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from KershawChang as a code owner February 3, 2025 08:51
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Feb 3, 2025
@larseggert larseggert enabled auto-merge February 3, 2025 08:56
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (6cdbc0c) to head (8cc7afc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
+ Coverage   95.26%   95.28%   +0.02%     
==========================================
  Files         114      114              
  Lines       36903    36903              
  Branches    36903    36903              
==========================================
+ Hits        35155    35163       +8     
+ Misses       1742     1732      -10     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert added this pull request to the merge queue Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 108fb8d.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Merged via the queue into main with commit 384b4bc Feb 3, 2025
63 of 66 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/lukemathwalker/cargo-chef-ca7d16daba13bfc84d947cb16f54cdaf547c830b4292e58618ccb4747202ef23 branch February 3, 2025 09:23
Copy link

github-actions bot commented Feb 3, 2025

Benchmark results

Performance differences relative to 6cdbc0c.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.877 µs 11.911 µs 11.952 µs]
       change: [-0.4447% +0.2569% +1.1060%] (p = 0.57 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
5 (5.00%) low severe
3 (3.00%) low mild
2 (2.00%) high mild
9 (9.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0769 ms 3.0865 ms 3.0975 ms]
       change: [-0.2870% +0.1500% +0.6214%] (p = 0.51 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.854 µs 19.914 µs 19.981 µs]
       change: [-0.3069% +0.0222% +0.3531%] (p = 0.90 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
1 (1.00%) low severe
2 (2.00%) low mild
3 (3.00%) high mild
14 (14.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.1659 ms 5.1789 ms 5.1937 ms]
       change: [-0.2200% +0.1389% +0.5231%] (p = 0.45 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
15 (15.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.9036 µs 6.9333 µs 6.9693 µs]
       change: [-0.3779% +0.3654% +1.3765%] (p = 0.47 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
6 (6.00%) low mild
10 (10.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7594 ms 1.7609 ms 1.7638 ms]
       change: [+0.0460% +0.1334% +0.2915%] (p = 0.05 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [93.003 ns 93.277 ns 93.552 ns]
       change: [-0.2510% +0.2235% +0.7331%] (p = 0.37 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
8 (8.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [110.47 ns 110.82 ns 111.19 ns]
       change: [-0.5635% -0.0464% +0.3950%] (p = 0.86 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
3 (3.00%) low mild
3 (3.00%) high mild
12 (12.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [110.02 ns 110.51 ns 111.09 ns]
       change: [-0.4240% +0.0594% +0.4885%] (p = 0.82 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) low mild
1 (1.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [92.526 ns 97.732 ns 109.26 ns]
       change: [-0.0150% +2.9026% +9.0158%] (p = 0.20 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
6 (6.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.78 ms 111.92 ms 112.14 ms]
       change: [-0.1052% +0.0342% +0.2806%] (p = 0.78 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) low mild
1 (1.00%) high mild
1 (1.00%) high severe

SentPackets::take_ranges: Change within noise threshold.
       time:   [5.1919 µs 5.3716 µs 5.5651 µs]
       change: [+0.0993% +2.7926% +5.6745%] (p = 0.05 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) high mild
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [40.738 ms 40.812 ms 40.887 ms]
       change: [+0.2474% +0.4875% +0.7269%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [40.878 ms 40.948 ms 41.019 ms]
       change: [+0.9548% +1.1879% +1.4372%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [40.432 ms 40.508 ms 40.585 ms]
       change: [-0.4782% -0.1827% +0.0910%] (p = 0.23 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [40.787 ms 40.854 ms 40.920 ms]
       change: [+0.4018% +0.6461% +0.8847%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved.
       time:   [852.68 ms 863.16 ms 873.83 ms]
       thrpt:  [114.44 MiB/s 115.85 MiB/s 117.28 MiB/s]
change:
       time:   [-4.9817% -3.3062% -1.5719%] (p = 0.00 < 0.05)
       thrpt:  [+1.5970% +3.4192% +5.2429%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [313.12 ms 315.51 ms 317.95 ms]
       thrpt:  [31.451 Kelem/s 31.695 Kelem/s 31.936 Kelem/s]
change:
       time:   [-1.4472% -0.4735% +0.5805%] (p = 0.36 > 0.05)
       thrpt:  [-0.5772% +0.4757% +1.4685%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [34.036 ms 34.240 ms 34.468 ms]
       thrpt:  [29.013  elem/s 29.205  elem/s 29.380  elem/s]
change:
       time:   [-1.0973% -0.2897% +0.5013%] (p = 0.49 > 0.05)
       thrpt:  [-0.4988% +0.2906% +1.1094%]

Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.5948 s 1.6121 s 1.6298 s]
       thrpt:  [61.358 MiB/s 62.029 MiB/s 62.704 MiB/s]
change:
       time:   [-2.0503% -0.6005% +0.8351%] (p = 0.42 > 0.05)
       thrpt:  [-0.8282% +0.6041% +2.0932%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 529.3 ± 46.8 501.0 658.7
neqo gquiche reno on 1504 738.3 ± 6.7 724.7 748.7
neqo gquiche reno 1504 747.9 ± 12.1 728.8 761.9
neqo gquiche cubic on 1504 733.6 ± 12.7 711.5 751.5
neqo gquiche cubic 1504 745.6 ± 30.5 716.7 828.5
msquic msquic 1504 97.2 ± 8.2 89.9 117.3
neqo msquic reno on 1504 217.3 ± 17.1 194.7 254.2
neqo msquic reno 1504 207.7 ± 10.9 194.5 224.2
neqo msquic cubic on 1504 216.8 ± 15.4 195.1 245.5
neqo msquic cubic 1504 214.5 ± 13.0 202.0 244.6
gquiche neqo reno on 1504 658.1 ± 76.7 549.0 767.6
gquiche neqo reno 1504 654.7 ± 84.7 538.3 801.1
gquiche neqo cubic on 1504 654.5 ± 74.6 539.7 754.0
gquiche neqo cubic 1504 649.8 ± 71.0 539.0 749.3
msquic neqo reno on 1504 477.8 ± 30.5 454.6 561.2
msquic neqo reno 1504 449.0 ± 10.5 435.7 473.0
msquic neqo cubic on 1504 483.9 ± 51.3 446.3 618.9
msquic neqo cubic 1504 455.1 ± 11.5 443.9 480.7
neqo neqo reno on 1504 420.9 ± 10.1 413.3 446.1
neqo neqo reno 1504 436.5 ± 10.2 422.1 457.7
neqo neqo cubic on 1504 449.6 ± 9.2 432.8 464.5
neqo neqo cubic 1504 436.4 ± 10.2 422.6 458.1

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant