ci: Only cache Rust artifacts from main runs
#2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To hopefully reduce cache pressure.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
==========================================
+ Coverage 95.25% 95.27% +0.01%
==========================================
Files 114 114
Lines 36999 36999
Branches 36999 36999
==========================================
+ Hits 35243 35249 +6
+ Misses 1750 1744 -6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to e365730. decode 4096 bytes, mask ff: No change in performance detected. time: [11.794 µs 11.833 µs 11.876 µs]
change: [-4.2071% -1.2852% +0.5067%] (p = 0.47 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8999 ms 2.9074 ms 2.9164 ms]
change: [-0.3804% +0.0126% +0.4276%] (p = 0.95 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.693 µs 19.790 µs 19.942 µs]
change: [-0.4010% +0.2612% +0.9681%] (p = 0.47 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.7133 ms 4.7243 ms 4.7370 ms]
change: [-0.3068% +0.0454% +0.4047%] (p = 0.78 > 0.05)
decode 4096 bytes, mask 3f: Change within noise threshold. time: [6.2340 µs 6.2693 µs 6.3104 µs]
change: [+0.0273% +0.5941% +1.1375%] (p = 0.04 < 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [2.1137 ms 2.1207 ms 2.1289 ms]
change: [-0.5732% -0.0589% +0.4586%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [93.072 ns 93.316 ns 93.572 ns]
change: [-1.3180% -0.5026% +0.0994%] (p = 0.18 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.65 ns 110.98 ns 111.34 ns]
change: [-1.4410% -0.1456% +1.0457%] (p = 0.85 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [110.30 ns 110.74 ns 111.26 ns]
change: [-0.5054% -0.0623% +0.3677%] (p = 0.80 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [92.738 ns 97.685 ns 108.80 ns]
change: [+0.0436% +3.1393% +9.5849%] (p = 0.19 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.93 ms 111.99 ms 112.04 ms]
change: [-0.0520% +0.0125% +0.0802%] (p = 0.72 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2260 µs 5.3756 µs 5.5282 µs]
change: [-4.4641% +4.7631% +22.225%] (p = 0.67 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [40.057 ms 40.143 ms 40.237 ms]
change: [-0.8142% -0.4960% -0.1859%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [40.164 ms 40.240 ms 40.321 ms]
change: [-0.3756% -0.1010% +0.1756%] (p = 0.48 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [40.003 ms 40.091 ms 40.184 ms]
change: [-0.7821% -0.4692% -0.1378%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [40.179 ms 40.258 ms 40.347 ms]
change: [-2.0223% -1.7649% -1.4761%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [843.92 ms 853.62 ms 863.69 ms]
thrpt: [115.78 MiB/s 117.15 MiB/s 118.49 MiB/s]
change:
time: [-3.4727% -1.7856% +0.0137%] (p = 0.04 < 0.05)
thrpt: [-0.0137% +1.8180% +3.5976%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [313.00 ms 316.56 ms 320.19 ms]
thrpt: [31.231 Kelem/s 31.590 Kelem/s 31.949 Kelem/s]
change:
time: [-3.6648% -2.1319% -0.5892%] (p = 0.01 < 0.05)
thrpt: [+0.5926% +2.1783% +3.8042%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.507 ms 25.649 ms 25.796 ms]
thrpt: [38.766 elem/s 38.987 elem/s 39.206 elem/s]
change:
time: [-0.7352% +0.0780% +0.9155%] (p = 0.86 > 0.05)
thrpt: [-0.9071% -0.0779% +0.7407%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.9338 s 1.9546 s 1.9751 s]
thrpt: [50.631 MiB/s 51.161 MiB/s 51.713 MiB/s]
change:
time: [+3.1597% +4.7197% +6.3432%] (p = 0.00 < 0.05)
thrpt: [-5.9649% -4.5070% -3.0629%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hopefully reduce cache pressure.