ci: Check CI workflows with zizmor
#2413
Conversation
And fix the issues.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsNone ❓ Unsupported Interop TestsNone ❓ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 114 114
Lines 37111 37111
Branches 37111 37111
=======================================
Hits 35363 35363
Misses 1742 1742
Partials 6 6 ☔ View full report in Codecov by Sentry. |
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Benchmark resultsPerformance differences relative to ed0a053. decode 4096 bytes, mask ff: No change in performance detected. time: [11.827 µs 11.873 µs 11.924 µs]
change: [-0.6864% +0.2395% +1.2742%] (p = 0.65 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.9064 ms 2.9207 ms 2.9391 ms]
change: [-0.2659% +0.3333% +1.0238%] (p = 0.34 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.686 µs 19.743 µs 19.809 µs]
change: [-1.0730% -0.2516% +0.3173%] (p = 0.58 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.7169 ms 4.7299 ms 4.7445 ms]
change: [-0.2621% +0.1375% +0.5251%] (p = 0.49 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.2104 µs 6.2371 µs 6.2700 µs]
change: [-0.8264% -0.2108% +0.5341%] (p = 0.55 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [2.1153 ms 2.1323 ms 2.1596 ms]
change: [-0.4389% +0.4915% +1.9220%] (p = 0.48 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [93.182 ns 93.508 ns 93.833 ns]
change: [-0.4429% +0.0705% +0.6136%] (p = 0.82 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.65 ns 110.98 ns 111.33 ns]
change: [-0.3059% +0.0313% +0.3756%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [110.43 ns 111.37 ns 112.71 ns]
change: [-1.3447% -0.3916% +0.4941%] (p = 0.42 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [92.390 ns 92.504 ns 92.642 ns]
change: [-1.4598% -0.5633% +0.2991%] (p = 0.23 > 0.05)
RxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [115.61 ms 115.76 ms 116.00 ms]
change: [+2.0289% +2.1781% +2.3990%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2594 µs 5.4213 µs 5.5820 µs]
change: [-4.4075% +4.4640% +20.072%] (p = 0.66 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [38.554 ms 38.639 ms 38.731 ms]
change: [-4.3819% -4.0800% -3.7992%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [38.803 ms 38.877 ms 38.956 ms]
change: [-4.3862% -4.1173% -3.8398%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [38.525 ms 38.596 ms 38.675 ms]
change: [-4.6651% -4.3964% -4.1315%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [38.782 ms 38.859 ms 38.948 ms]
change: [-3.7565% -3.4805% -3.2003%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [859.18 ms 868.86 ms 878.69 ms]
thrpt: [113.81 MiB/s 115.09 MiB/s 116.39 MiB/s]
change:
time: [-1.0002% +0.6645% +2.3102%] (p = 0.42 > 0.05)
thrpt: [-2.2580% -0.6601% +1.0103%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [317.98 ms 321.59 ms 325.19 ms]
thrpt: [30.752 Kelem/s 31.095 Kelem/s 31.448 Kelem/s]
change:
time: [-0.8415% +0.7822% +2.4338%] (p = 0.35 > 0.05)
thrpt: [-2.3760% -0.7761% +0.8487%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.500 ms 25.662 ms 25.831 ms]
thrpt: [38.713 elem/s 38.968 elem/s 39.216 elem/s]
change:
time: [-1.1386% -0.2228% +0.6856%] (p = 0.64 > 0.05)
thrpt: [-0.6810% +0.2233% +1.1517%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.8469 s 1.8641 s 1.8809 s]
thrpt: [53.167 MiB/s 53.646 MiB/s 54.146 MiB/s]
change:
time: [-3.4917% -2.2276% -0.9128%] (p = 0.00 < 0.05)
thrpt: [+0.9212% +2.2783% +3.6180%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
changed the title
zizmor
|
Need to commit this to |
And fix the security issues it found.