Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use prebuilt nss #2414

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (5cb82c7) to head (c8375a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         114      114           
  Lines       36997    36997           
  Branches    36997    36997           
=======================================
  Hits        35247    35247           
  Misses       1744     1744           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 4, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 108fb8d.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Feb 4, 2025

Benchmark results

Performance differences relative to ed0a053.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.829 µs 11.884 µs 11.947 µs]
       change: [-0.8650% -0.1222% +0.6439%] (p = 0.76 > 0.05)

Found 25 outliers among 100 measurements (25.00%)
4 (4.00%) low severe
6 (6.00%) low mild
15 (15.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [2.9049 ms 2.9145 ms 2.9258 ms]
       change: [-0.4039% +0.1216% +0.6345%] (p = 0.65 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
10 (10.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.664 µs 19.704 µs 19.751 µs]
       change: [-1.1642% -0.3523% +0.2016%] (p = 0.40 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
5 (5.00%) low mild
1 (1.00%) high mild
9 (9.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [4.7148 ms 4.7261 ms 4.7391 ms]
       change: [-0.3021% +0.0585% +0.4124%] (p = 0.75 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.2085 µs 6.2308 µs 6.2593 µs]
       change: [-0.8192% -0.3320% +0.1623%] (p = 0.20 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [2.1134 ms 2.1277 ms 2.1520 ms]
       change: [-0.5978% +0.2726% +1.4728%] (p = 0.68 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [93.366 ns 93.702 ns 94.039 ns]
       change: [-0.2758% +0.2407% +0.8051%] (p = 0.37 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
10 (10.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [110.67 ns 110.97 ns 111.29 ns]
       change: [-0.3759% -0.0692% +0.2380%] (p = 0.67 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
3 (3.00%) low severe
2 (2.00%) low mild
6 (6.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [110.41 ns 110.89 ns 111.47 ns]
       change: [-1.5244% -0.6045% +0.0983%] (p = 0.16 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
5 (5.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [92.334 ns 92.466 ns 92.618 ns]
       change: [-1.5483% -0.6425% +0.1897%] (p = 0.16 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.89 ms 112.02 ms 112.22 ms]
       change: [-1.2493% -1.1229% -0.9181%] (p = 0.00 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
6 (6.00%) low mild
4 (4.00%) high mild
1 (1.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [5.2682 µs 5.4517 µs 5.6470 µs]
       change: [-4.1329% +4.7647% +20.177%] (p = 0.64 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [39.857 ms 39.936 ms 40.017 ms]
       change: [-1.1534% -0.8587% -0.5660%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [40.143 ms 40.216 ms 40.289 ms]
       change: [-1.0788% -0.8156% -0.5415%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [39.689 ms 39.774 ms 39.860 ms]
       change: [-1.7743% -1.4784% -1.1814%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [40.005 ms 40.076 ms 40.148 ms]
       change: [-0.7360% -0.4593% -0.1874%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💔 Performance has regressed.
       time:   [884.53 ms 893.06 ms 901.98 ms]
       thrpt:  [110.87 MiB/s 111.97 MiB/s 113.05 MiB/s]
change:
       time:   [+1.8551% +3.4686% +4.9667%] (p = 0.00 < 0.05)
       thrpt:  [-4.7317% -3.3524% -1.8213%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [318.29 ms 321.51 ms 324.75 ms]
       thrpt:  [30.793 Kelem/s 31.103 Kelem/s 31.418 Kelem/s]
change:
       time:   [-0.7497% +0.7567% +2.2787%] (p = 0.34 > 0.05)
       thrpt:  [-2.2279% -0.7510% +0.7554%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [25.435 ms 25.584 ms 25.734 ms]
       thrpt:  [38.860  elem/s 39.088  elem/s 39.316  elem/s]
change:
       time:   [-1.4326% -0.5284% +0.3656%] (p = 0.25 > 0.05)
       thrpt:  [-0.3643% +0.5312% +1.4534%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.8713 s 1.8867 s 1.9021 s]
       thrpt:  [52.573 MiB/s 53.003 MiB/s 53.438 MiB/s]
change:
       time:   [-2.2810% -1.0404% +0.2026%] (p = 0.11 > 0.05)
       thrpt:  [-0.2022% +1.0514% +2.3342%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 527.9 ± 48.4 492.6 638.4
neqo gquiche reno on 1504 772.2 ± 43.2 731.3 879.4
neqo gquiche reno 1504 734.9 ± 34.2 700.8 826.7
neqo gquiche cubic on 1504 737.0 ± 15.0 709.6 752.6
neqo gquiche cubic 1504 758.1 ± 11.9 742.8 776.1
msquic msquic 1504 141.4 ± 74.2 91.7 355.3
neqo msquic reno on 1504 224.1 ± 20.7 202.1 286.8
neqo msquic reno 1504 279.3 ± 130.1 201.2 659.2
neqo msquic cubic on 1504 208.7 ± 11.6 195.3 236.9
neqo msquic cubic 1504 211.8 ± 16.3 195.6 248.7
gquiche neqo reno on 1504 679.4 ± 88.6 547.5 811.2
gquiche neqo reno 1504 640.4 ± 81.9 504.8 763.1
gquiche neqo cubic on 1504 732.7 ± 154.3 555.1 1107.4
gquiche neqo cubic 1504 658.7 ± 77.8 534.8 775.3
msquic neqo reno on 1504 445.0 ± 7.2 437.9 458.4
msquic neqo reno 1504 444.1 ± 5.3 438.3 455.7
msquic neqo cubic on 1504 451.8 ± 12.0 435.9 473.7
msquic neqo cubic 1504 497.1 ± 88.0 439.6 669.3
neqo neqo reno on 1504 433.2 ± 12.3 414.3 457.4
neqo neqo reno 1504 421.4 ± 10.4 408.0 443.6
neqo neqo cubic on 1504 443.5 ± 9.0 432.0 459.3
neqo neqo cubic 1504 443.2 ± 8.4 433.2 457.0

⬇️ Download logs

@larseggert larseggert merged commit e682ede into mozilla:main Feb 4, 2025
65 of 69 checks passed
@larseggert larseggert deleted the ci-qns-prebuilt-nss branch February 4, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant