feat: Replace HashMap with EnumMap
#2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
- Coverage 95.27% 95.26% -0.02%
==========================================
Files 115 115
Lines 37135 37148 +13
Branches 37135 37148 +13
==========================================
+ Hits 35381 35388 +7
- Misses 1748 1754 +6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to cb058cb. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to db807a9. decode 4096 bytes, mask ff: No change in performance detected. time: [12.334 µs 12.380 µs 12.431 µs]
change: [-0.5322% -0.0025% +0.5342%] (p = 0.99 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8368 ms 2.8465 ms 2.8576 ms]
change: [-0.6432% -0.0534% +0.4982%] (p = 0.86 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.894 µs 20.959 µs 21.023 µs]
change: [-0.2198% +0.1764% +0.6479%] (p = 0.44 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.5385 ms 4.5497 ms 4.5625 ms]
change: [-0.4075% -0.0407% +0.3471%] (p = 0.83 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2651 µs 8.2976 µs 8.3353 µs]
change: [-0.4903% -0.0676% +0.3358%] (p = 0.75 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5873 ms 1.5928 ms 1.5996 ms]
change: [-0.5924% -0.0668% +0.4568%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.308 ns 91.685 ns 92.089 ns]
change: [-0.2580% +0.2160% +0.7310%] (p = 0.41 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.61 ns 109.84 ns 110.09 ns]
change: [-0.5161% +0.1877% +1.0713%] (p = 0.69 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.49 ns 110.04 ns 110.67 ns]
change: [-0.4625% +0.0843% +0.5819%] (p = 0.76 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.614 ns 98.663 ns 109.66 ns]
change: [-0.1034% +2.8684% +7.3068%] (p = 0.18 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [112.27 ms 112.41 ms 112.64 ms]
change: [+0.0014% +0.1397% +0.3572%] (p = 0.12 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2452 µs 5.3967 µs 5.5572 µs]
change: [-4.7654% -1.3792% +1.9904%] (p = 0.43 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [36.183 ms 36.247 ms 36.313 ms]
change: [-5.4827% -5.2168% -4.9476%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [36.291 ms 36.364 ms 36.440 ms]
change: [-5.0832% -4.7906% -4.5015%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [35.871 ms 35.948 ms 36.033 ms]
change: [-5.7859% -5.5251% -5.2545%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [36.038 ms 36.111 ms 36.197 ms]
change: [-5.9413% -5.6539% -5.3758%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [859.40 ms 869.31 ms 879.49 ms]
thrpt: [113.70 MiB/s 115.03 MiB/s 116.36 MiB/s]
change:
time: [-0.8680% +0.9850% +2.8931%] (p = 0.28 > 0.05)
thrpt: [-2.8117% -0.9754% +0.8756%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [320.51 ms 323.96 ms 327.43 ms]
thrpt: [30.541 Kelem/s 30.868 Kelem/s 31.201 Kelem/s]
change:
time: [-1.9577% -0.4662% +1.0151%] (p = 0.54 > 0.05)
thrpt: [-1.0049% +0.4684% +1.9968%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.436 ms 25.610 ms 25.786 ms]
thrpt: [38.780 elem/s 39.047 elem/s 39.315 elem/s]
change:
time: [-0.3279% +0.5980% +1.5086%] (p = 0.21 > 0.05)
thrpt: [-1.4862% -0.5945% +0.3289%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.8145 s 1.8305 s 1.8467 s]
thrpt: [54.151 MiB/s 54.630 MiB/s 55.110 MiB/s]
change:
time: [-2.7130% -1.3346% +0.0558%] (p = 0.06 > 0.05)
thrpt: [-0.0558% +1.3527% +2.7887%]
Client/server transfer resultsPerformance differences relative to db807a9. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
mxinden
approved these changes
Feb 10, 2025
martinthomson
approved these changes
Feb 10, 2025
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <lars@eggert.org>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places.