chore: Convert FrameType to an enum
#2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
==========================================
- Coverage 95.27% 92.81% -2.46%
==========================================
Files 115 115
Lines 37135 37198 +63
Branches 37135 37198 +63
==========================================
- Hits 35381 34527 -854
- Misses 1748 1822 +74
- Partials 6 849 +843 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to db807a9. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Signed-off-by: Lars Eggert <lars@eggert.org>
Benchmark resultsPerformance differences relative to d21c121. decode 4096 bytes, mask ff: No change in performance detected. time: [12.345 µs 12.395 µs 12.448 µs]
change: [-0.4244% +0.1166% +0.5414%] (p = 0.65 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8368 ms 2.8467 ms 2.8578 ms]
change: [-1.3856% -0.2873% +0.5194%] (p = 0.63 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.851 µs 20.905 µs 20.962 µs]
change: [-0.3284% +0.1232% +0.5671%] (p = 0.60 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.5387 ms 4.5499 ms 4.5627 ms]
change: [-0.4865% -0.0903% +0.3235%] (p = 0.65 > 0.05)
decode 4096 bytes, mask 3f: Change within noise threshold. time: [8.2512 µs 8.2594 µs 8.2736 µs]
change: [-1.4218% -0.7303% -0.0914%] (p = 0.03 < 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5884 ms 1.5940 ms 1.6009 ms]
change: [-0.4608% +0.0661% +0.5977%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.169 ns 91.441 ns 91.714 ns]
change: [-1.2577% -0.4105% +0.2840%] (p = 0.34 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.87 ns 110.27 ns 110.73 ns]
change: [-0.3083% +0.1111% +0.5257%] (p = 0.61 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.28 ns 109.66 ns 110.13 ns]
change: [-1.1425% -0.4068% +0.2400%] (p = 0.26 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.424 ns 93.554 ns 93.689 ns]
change: [-1.1431% -0.0373% +1.2548%] (p = 0.95 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [112.26 ms 112.40 ms 112.63 ms]
change: [-0.1932% +0.0059% +0.2541%] (p = 0.97 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2519 µs 5.4466 µs 5.6486 µs]
change: [-1.4441% +1.4738% +4.3981%] (p = 0.33 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [34.456 ms 34.527 ms 34.601 ms]
change: [-0.2938% +0.0079% +0.2914%] (p = 0.96 > 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [34.749 ms 34.826 ms 34.912 ms]
change: [+0.1800% +0.4437% +0.7462%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.695 ms 34.745 ms 34.796 ms]
change: [+0.4179% +0.6234% +0.8242%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [34.888 ms 34.950 ms 35.012 ms]
change: [+0.2746% +0.5398% +0.8086%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [825.62 ms 835.90 ms 846.54 ms]
thrpt: [118.13 MiB/s 119.63 MiB/s 121.12 MiB/s]
change:
time: [-5.4228% -3.7642% -2.1456%] (p = 0.00 < 0.05)
thrpt: [+2.1927% +3.9114% +5.7337%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [313.79 ms 317.01 ms 320.21 ms]
thrpt: [31.229 Kelem/s 31.545 Kelem/s 31.868 Kelem/s]
change:
time: [-2.2833% -0.7774% +0.6263%] (p = 0.30 > 0.05)
thrpt: [-0.6224% +0.7834% +2.3366%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.391 ms 25.546 ms 25.704 ms]
thrpt: [38.904 elem/s 39.146 elem/s 39.383 elem/s]
change:
time: [-1.8081% -0.8904% +0.0209%] (p = 0.06 > 0.05)
thrpt: [-0.0209% +0.8984% +1.8414%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.8393 s 1.8575 s 1.8761 s]
thrpt: [53.302 MiB/s 53.835 MiB/s 54.368 MiB/s]
change:
time: [-1.1138% +0.3365% +1.6606%] (p = 0.63 > 0.05)
thrpt: [-1.6335% -0.3353% +1.1264%]
Client/server transfer resultsPerformance differences relative to d21c121. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Closed
mxinden
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.