test: Add a bench for H3 streams #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
+ Coverage 95.39% 95.41% +0.02%
==========================================
Files 115 115
Lines 36982 36982
Branches 36982 36982
==========================================
+ Hits 35279 35288 +9
+ Misses 1697 1686 -11
- Partials 6 8 +2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 1df2a5a. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 1df2a5a. decode 4096 bytes, mask ff: No change in performance detected. time: [12.323 µs 12.363 µs 12.408 µs]
change: [-1.1214% -0.2678% +0.4040%] (p = 0.56 > 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.8364 ms 2.8459 ms 2.8570 ms]
change: [-8.1347% -7.7305% -7.2893%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.838 µs 20.889 µs 20.945 µs]
change: [-0.7399% -0.2000% +0.2626%] (p = 0.46 > 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.5412 ms 4.5524 ms 4.5652 ms]
change: [-13.113% -12.813% -12.516%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2538 µs 8.2759 µs 8.3058 µs]
change: [-0.5772% -0.1238% +0.3226%] (p = 0.60 > 0.05)
decode 1048576 bytes, mask 3f: 💚 Performance has improved. time: [1.5885 ms 1.5941 ms 1.6010 ms]
change: [-9.6661% -9.3475% -8.9530%] (p = 0.00 < 0.05)
1 streams of 1 bytes/multistream:time: [66.498 µs 66.655 µs 66.818 µs] Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild 1000 streams of 1 bytes/multistream:time: [24.304 ms 24.378 ms 24.492 ms] Found 2 outliers among 100 measurements (2.00%) 1 (1.00%) high mild 1 (1.00%) high severe 10000 streams of 1 bytes/multistream:time: [1.6554 s 1.6568 s 1.6582 s] Found 10 outliers among 100 measurements (10.00%) 4 (4.00%) low mild 3 (3.00%) high mild 3 (3.00%) high severe 1 streams of 1000 bytes/multistream:time: [68.011 µs 68.630 µs 69.656 µs] Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high severe 100 streams of 1000 bytes/multistream:time: [3.2353 ms 3.2416 ms 3.2483 ms] Found 19 outliers among 100 measurements (19.00%) 19 (19.00%) high severe 1000 streams of 1000 bytes/multistream:time: [143.70 ms 143.86 ms 144.08 ms] Found 2 outliers among 100 measurements (2.00%) 1 (1.00%) high mild 1 (1.00%) high severe coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [89.814 ns 90.091 ns 90.378 ns]
change: [-1.7045% -1.2607% -0.8230%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: 💚 Performance has improved. time: [107.14 ns 107.38 ns 107.65 ns]
change: [-3.4252% -2.7453% -2.2138%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💚 Performance has improved. time: [106.86 ns 107.33 ns 107.87 ns]
change: [-3.4218% -2.6452% -2.0097%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: 💚 Performance has improved. time: [89.045 ns 89.138 ns 89.249 ns]
change: [-6.4726% -5.2615% -4.2218%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.71 ms 112.85 ms 113.07 ms]
change: [+0.3578% +0.4965% +0.6923%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.1533 µs 5.2306 µs 5.3053 µs]
change: [-4.5830% -1.7948% +0.8487%] (p = 0.20 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [34.095 ms 34.160 ms 34.232 ms]
change: [-0.6088% -0.3366% -0.0437%] (p = 0.02 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [33.949 ms 34.010 ms 34.074 ms]
change: [-1.5808% -1.3434% -1.0951%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [33.996 ms 34.052 ms 34.113 ms]
change: [-2.2398% -1.9537% -1.6959%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [34.339 ms 34.408 ms 34.477 ms]
change: [-1.6743% -1.3822% -1.1021%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [864.63 ms 875.41 ms 886.49 ms]
thrpt: [112.81 MiB/s 114.23 MiB/s 115.66 MiB/s]
change:
time: [-0.6219% +1.2435% +3.1174%] (p = 0.19 > 0.05)
thrpt: [-3.0231% -1.2283% +0.6258%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: 💚 Performance has improved. time: [312.27 ms 315.53 ms 318.86 ms]
thrpt: [31.362 Kelem/s 31.693 Kelem/s 32.023 Kelem/s]
change:
time: [-4.1932% -2.7389% -1.3161%] (p = 0.00 < 0.05)
thrpt: [+1.3336% +2.8161% +4.3767%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.334 ms 25.500 ms 25.670 ms]
thrpt: [38.956 elem/s 39.216 elem/s 39.473 elem/s]
change:
time: [-0.8876% -0.0415% +0.8907%] (p = 0.93 > 0.05)
thrpt: [-0.8829% +0.0415% +0.8955%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.8118 s 1.8296 s 1.8479 s]
thrpt: [54.115 MiB/s 54.656 MiB/s 55.195 MiB/s]
change:
time: [-3.8930% -2.5789% -1.2628%] (p = 0.00 < 0.05)
thrpt: [+1.2790% +2.6471% +4.0506%]
Client/server transfer resultsPerformance differences relative to 1df2a5a. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
approved these changes
Feb 18, 2025
Co-authored-by: Max Inden <mail@max-inden.de> Signed-off-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see if the hasher changes in #2342 make sense.
Also remove some related redundancies in
test-fixturewhile I'm here.