Remove calendar_quarter_t5 #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most code is commented for later return if desired
r-ash
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
This looks fine to me, I will say I'm generally not a fan of commenting out code like this, I feel like it makes reading the actual code that is there harder and tends to go stale. So if it was me, I would just remove it, we can always refer back to this PR if we want to add it back in. But up to you if you'd rather keep that in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove now unused
calendar_quarter_t5option and projection step.Most code is retained but simply commented out.
Merge after #464.
Coincides with UI model options page update: mrc-ide/naomi.options#27
May have implications for hintr — unsure