Tidy up role controller endpoints. #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the role endpoint from `/role` to `/roles`, bringing it inline with the existing `/packets` and `/packetGroups`. This also removes the `GET /roles/names` endpoint, which was not being used anywhere, and which overlapped with the existing `GET /roles/<name>` which is used to get details about a particular role. Having both routes could cause issue is a role was named `names`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 97.18% 97.20% +0.02%
==========================================
Files 149 149
Lines 1422 1433 +11
Branches 406 416 +10
==========================================
+ Hits 1382 1393 +11
Misses 39 39
Partials 1 1 ☔ View full report in Codecov by Sentry. |
plietar
force-pushed
the
roles-controller
branch
from
c18623a to
106fa27
Compare
EmmaLRussell
reviewed
Feb 6, 2025
| @@ -26,8 +26,9 @@ interface DeleteUserOrRoleProps { | |||
| export const DeleteUserOrRole = ({ mutate, data: { name, type } }: DeleteUserOrRoleProps) => { | |||
| const onDelete = async (roleName: string) => { | |||
| try { | |||
| const endpoint = type === "role" ? "roles" : type; | |||
There was a problem hiding this comment.
This suggests we should maybe pluralise the user endpoints next!
Co-authored-by: Emma Russell <44669576+EmmaLRussell@users.noreply.github.com>
EmmaLRussell
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the role endpoint from
/roleto/roles, bringing it inline with the existing/packetsand/packetGroups.This also removes the
GET /roles/namesendpoint, which was not being used anywhere, and which overlapped with the existingGET /roles/<name>which is used to get details about a particular role. Having both routes could cause issue is a role was namednames.