Added new DevTools #30870
Draft
Added new DevTools #30870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mugen87
reviewed
Apr 5, 2025
Mugen87
reviewed
Apr 5, 2025
|
Nice! I feel like |
|
It's on the Chrome Store already in case anyone wants to try it: |
I'll make that work today. We need to add some code to WebGPURenderer though. |
The devtools Chrome extension injects `bridge.js` directly into the page content. As a result, any top-level definitions in `bridge.js` are set on `window`. This resulted in `window.dispatchEvent` being overwritten, which interfered with normal use of `window.dispatchEvent` by any site that relied on it. This change wraps the entire `bridge.js` file in an anonymous function to prevent any littering of the `window` objcect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started a new and simpler Three.js DevTools.