Merge pull request #159 from mreutegg/httpclient5

Update to httpclient5
mreutegg · Jan 19, 2025 · a65e3d4 · a65e3d4
2 parents e98cc1d + c604352
commit a65e3d4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -133,9 +133,9 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>org.apache.httpcomponents</groupId>
-            <artifactId>httpclient</artifactId>
-            <version>4.5.14</version>
+            <groupId>org.apache.httpcomponents.client5</groupId>
+            <artifactId>httpclient5</artifactId>
+            <version>5.4.1</version>
             <scope>test</scope>
         </dependency>
         <dependency>

diff --git a/src/test/java/com/github/mreutegg/laszip4j/DataFiles.java b/src/test/java/com/github/mreutegg/laszip4j/DataFiles.java
@@ -16,10 +16,9 @@
  */
 package com.github.mreutegg.laszip4j;
 
-import org.apache.http.client.methods.CloseableHttpResponse;
-import org.apache.http.client.methods.HttpGet;
-import org.apache.http.impl.client.CloseableHttpClient;
-import org.apache.http.impl.client.HttpClients;
+import org.apache.hc.client5.http.classic.methods.HttpGet;
+import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
+import org.apache.hc.client5.http.impl.classic.HttpClients;
 import org.junit.rules.ExternalResource;
 
 import java.io.File;
@@ -80,11 +79,12 @@ public void download() throws Exception {
     private static void download(String uri, File file) throws Exception {
         URI url = new URI(uri);
         try (CloseableHttpClient client = HttpClients.createDefault()) {
-            try (CloseableHttpResponse response = client.execute(new HttpGet(url))) {
+            client.execute(new HttpGet(url), response -> {
                 try (OutputStream out = Files.newOutputStream(file.toPath())) {
                     response.getEntity().writeTo(out);
                 }
-            }
+                return true;
+            });
         }
     }
 }