Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning 1.0 release #275

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

Planning 1.0 release #275

wants to merge 76 commits into from

Conversation

SemyonSinchenko
Copy link
Collaborator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers. If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

nijanthanvijayakumar and others added 30 commits July 8, 2024 11:49
Deprecate and remove `exists` and `forall` functions from the codebase.
* Remove `exists` and `forall` functions from `quinn/functions.py`.
* Remove import statements for `exists` and `forall` from `quinn/__init__.py`.
* Remove tests related to `exists` and `forall` functions from `tests/test_functions.py`.
* According to one of the points in the issue #199 by @MrPowers, this function should never have been created.
* This particular commit removes this function and its references from the quinn repo.
…emove-athena-func

Remove the print Athena function
…sts-forall

Issue 49 remove exists forall
Related to #237

Remove deprecated extension functions from the codebase
* Delete `quinn/extensions/dataframe_ext.py` and `quinn/extensions/spark_session_ext.py`
* Remove import statements for `dataframe_ext` and `spark_session_ext` in `quinn/extensions/__init__.py`
* Remove per-file ignores for `quinn/extensions/dataframe_ext.py` and `quinn/extensions/__init__.py` in `pyproject.toml`
* Delete test files `tests/extensions/test_dataframe_ext.py` and `tests/extensions/test_spark_session_ext.py`
Since the extensions functions have been removed, remove the corresponding package/directory and the `__init__.py` file too.
The following functions have been removed from the init file
* print_athena_create_table
* exists
* forall
* Create the `extensions/` directory.
* Create the `__init__.py` file within it with the license header.
* Create the `spark_session_ext.py` file within the extensions directory
* Update the doc-string in create_df to align with the parameter list.
* Format modified files & lint the code using ruff (successful)
As a matter of fact, a create_df function already exists under the
dataframe_helpers.py Following are the changes introduced by this commit.
* Update `dataframe_helpers.py` by updating the doc-string in the create_df function.
* Remove quinn/extensions/ directory along with the two `.py` files involved.
* Remove the ruff check from the pyproject.toml.
* Finally, format the dataframe_helpers.py with ruff
- Update deps
- Update Ruff
- Corresponding updates of pyproject
- Slightly update Makefile
- Drop Support of Spark2
- Drop Support of Spark 3.1-3.2
- Minimal python is 3.10 from now
- Apply new ruff rules
- Apply ruff linter

 On branch 202-drop-pyspark2
 Changes to be committed:
	modified:   .github/workflows/ci.yml
	modified:   Makefile
	modified:   poetry.lock
	modified:   pyproject.toml
	modified:   quinn/append_if_schema_identical.py
	modified:   quinn/dataframe_helpers.py
	modified:   quinn/keyword_finder.py
	modified:   quinn/math.py
	modified:   quinn/schema_helpers.py
	modified:   quinn/split_columns.py
	modified:   quinn/transformations.py
…emove-extensions

Remove the extensions functions
Drop Spark-2 support and update dependencies
This commit introduces the following changes:
* Updates the `ci.yml` file by introducing a new step under the `test` job to perform tests using Spark-Connect.
* Creates a shell-script that downloads & installs Spark binaries and then runs the Spark-Connect server.
* Creates a pytest module/file that tests a very simple function on Spark-Connect.
* Updates the Makefile to add a new step for the Spark-Connect tests.
fpgmaas and others added 26 commits July 15, 2024 13:37
update makefile

add make command for ruff
Improve pre-commit hooks and use of ruff
This was included to perform the GH Actions on the feature/ branches to speed up the development & test when working on the Spark-Connect tests upgrade.
…ntegrate-sc-tests

Integrate the Spark-Connect tests with the existing test suite & CI
…262)

* Add configuration files for release-please and update contributing guide

* **release-please-config.json**: Add configuration file with release type set to `python`, changelog path to `CHANGELOG.md`, and packages to include `quinn`.
* **.release-please-manifest.json**: Add manifest file with `quinn` version set to `1.0.0`.
* **.github/workflows/release-please.yml**: Add workflow file for release-please action
* **CONTRIBUTING.md**: Add a section for the "Release Process"

* feat: Update the documentation to elaborate the release process

* feat: Update the release GH action to publish the package to PyPI
@SemyonSinchenko SemyonSinchenko self-assigned this Feb 26, 2025
@SemyonSinchenko SemyonSinchenko added the 1.0 Quinn 1.0 release label Feb 26, 2025
@SemyonSinchenko
Copy link
Collaborator Author

I will work on resolving conflicts and preparing for the merge.

@nijanthanvijayakumar
Copy link
Contributor

Thanks for merging the previous pull request @SemyonSinchenko . Glad to see the GitHub Actions pipeline working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Quinn 1.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants