Merge pull request #172 from mscharley/gh-171

Make ignored packages actually get excluded

.github/workflows/check-dist.yml

@@ -38,7 +38,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
-          node-version-file: .nvmrc
+          node-version-file: .tool-versions
           cache: npm
 
       - name: Install Dependencies

.github/workflows/ci.yml

@@ -23,7 +23,7 @@ jobs:
         id: setup-node
         uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
-          node-version-file: .nvmrc
+          node-version-file: .tool-versions
           cache: npm
 
       - name: Install Dependencies

.github/workflows/linter.yml

@@ -33,7 +33,7 @@ jobs:
         id: setup-node
         uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
-          node-version-file: .nvmrc
+          node-version-file: .tool-versions
           cache: npm
 
       - name: Install Dependencies

.tool-versions

@@ -0,0 +1 @@
+nodejs 20.14.0

.vscode/settings.default.json

@@ -1,5 +1,5 @@
 {
-	"jest.jestCommandLine": "${NVM_DIR:-~/.nvm}/nvm-exec npx jest",
+	"jest.jestCommandLine": "${ASDF_DATA_DIR:-~/.asdf}/shims/npx jest",
 	"eslint.options": {
 		"useEslintrc": false,
 		"overrideConfig": { "extends": ["./.github/linters/.eslintrc.yml"] }

src/__tests__/generateChangeset.test.ts

@@ -82,6 +82,23 @@ describe('generateChangeset', () => {
 	});
 
 	it('will exclude a package if it is listed as an ignored package for changesets', () => {
+		expect(
+			generateChangeset(
+				pr({}),
+				commit({ commit: { message: 'fix: hello, world' } }),
+				input({ useConventionalCommits: true }),
+				changesets({ ignore: ['@mscharley/test'] }),
+				{ foundChangeset: false },
+				[['package.json', { name: '@mscharley/test' }], ['package.json', { name: '@mscharley/test2' }]],
+			),
+		).toMatchObject<Changeset>({
+			affectedPackages: ['@mscharley/test2'],
+			message: 'fix: hello, world',
+			updateType: 'patch',
+		});
+	});
+
+	it('will exclude the changeset if only ignored packages are included', () => {
 		expect(
 			generateChangeset(
 				pr({}),

src/main.ts

@@ -1,4 +1,5 @@
 import { debug, setOutput } from '@actions/core';
+import { debugJson } from './io/debugJson';
 import { getCommitLog } from './io/github/getCommitLog';
 import { getEvent } from './io/getEvent';
 import { getFile } from './io/github/getFile';
@@ -29,7 +30,8 @@ export async function run(): Promise<void> {
 
 	const getFromGithub = getFile(octokit, owner, repo, ref);
 	const commits = await getCommitLog(octokit, owner, repo, pr);
-	const changesetsConfig = await getFromGithub(isChangesetsConfiguration)(`${input.changesetFolder}/config.json`);
+	const [, changesetsConfig] = await getFromGithub(isChangesetsConfiguration)(`${input.changesetFolder}/config.json`);
+	debugJson('Changesets configuration', changesetsConfig);
 
 	const patchString = await getPrPatch(octokit, owner, repo, pr.number);
 	const changeset = await processPullRequest(