fix: handle input validation better

mscharley · Nov 20, 2023 · 5da5e6b · 5da5e6b
1 parent 5d4104f
commit 5da5e6b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/badges/coverage.svg b/badges/coverage.svg
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/io/parseInput.ts b/src/io/parseInput.ts
@@ -2,6 +2,8 @@ import { getBooleanInput, getInput, warning } from '@actions/core';
 import { debugJson } from './debugJson';
 import { getOctokit } from '@actions/github';
 
+const USE_SEMANTIC_COMMITS = 'INPUT_USE-SEMANTIC-COMMITS';
+
 export interface ActionInput {
 	author?: {
 		name: string;
@@ -24,7 +26,7 @@ const getAuthor = (): undefined | { name: string; email: string } => {
 };
 
 export const parseInput = (): ActionInput => {
-	const hasSemanticCommitConfig = 'INPUT_USE-SEMANTIC-COMMITS' in process.env;
+	const hasSemanticCommitConfig = process.env[USE_SEMANTIC_COMMITS] != null && process.env[USE_SEMANTIC_COMMITS] !== '';
 	if (hasSemanticCommitConfig) {
 		warning(
 			'The use-semantic-commits option was renamed to use-conventional-commits and will be removed at some point',