"Downloader IP" in download history log: account for reverse-proxied requests #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for submitting this! Are you seeing this behavior with https://github.com/mtlynch/picoshare#environment-variables That should get you the correct IPs everywhere (e.g., in log files, error messages) rather than specifically in the download log. |
|
That indeed does the job. I hadn't read the README past all the Docker blah ;-) Please close! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried picoshare out today. Nice stuff!
I had stuck it behind a reverse proxy (Apache this time). But like this, in the download log (as under
/files/$THE_ID/downloads) the "Downloader IP" of all downloads would list the IP of the proxy...This PR will make it so that instead the client IP from the X-Forwarded-For header (which is, by convention, inserted by reverse HTTP proxies such as Apache and Nginx) is recorded.