Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP8 deprecation in Generator::getFormRules #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viki53
Copy link

@viki53 viki53 commented Mar 9, 2021

Fixes #60

To anyone already using this repo and needing to use this fix for the time being, you can use the following info in your composer.json:

    "repositories": {
        "laravel-swagger-php8": {
            "type": "package",
            "package": {
                "name": "mtrajano/laravel-swagger",
                "version": "0.6.5",
                "source": {
                    "url": "https://github.com/viki53/laravel-swagger.git",
                    "type": "git",
                    "reference": "origin/master"
                }
            }
        }
    },

This will override your version with my repo without needing to change your dependencies list, that way you can just remove this config later when this repo is updated with the fix.

@MaFx
Copy link

MaFx commented Mar 14, 2022

Hi @viki53 can you please add 8.0 and 8.1 to .travis.yml so builds are run for those versions?

@viki53
Copy link
Author

viki53 commented Mar 14, 2022

Done!

Let me know if there's anything else I can do to help :)

@mtrajano
Copy link
Owner

Hey @viki53 thank you for the pr, sorry I didn't get around to it sooner. I think there's still a few things clashing with 8.1 (At least one of them being that ArrayAccess::offsetExists now has a return type), might just be about adjusting the versions of passport and testbanch as well. Going to take a look a little bit later today and see if I can resolve those as well and fix these all at once

@viki53
Copy link
Author

viki53 commented Jul 25, 2022

@mtrajano Hi, sorry to bother you, is there any news? Do you need me to update/fix something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8 deprecation (ReflectionParameter::getClass())
3 participants